Add new *.impl.* package convention, internal code with japicmp compatibility#8325
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Apr 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8325 +/- ##
=========================================
Coverage 90.27% 90.27%
Complexity 7693 7693
=========================================
Files 850 850
Lines 23207 23207
Branches 2356 2356
=========================================
Hits 20951 20951
Misses 1530 1530
Partials 726 726 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y-java into new-impl-code-convention
trask
approved these changes
Apr 23, 2026
Member
trask
left a comment
There was a problem hiding this comment.
I like .impl
I assume there's nothing worth adding to VERSIONING.md since it's just a normal stable class from that perspective?
jaydeluca
approved these changes
Apr 24, 2026
Co-authored-by: Jay DeLuca <jaydeluca4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6970.
We need a new stability tier for code that is public (for cross-module access within the OpenTelemetry project) but not intended for application developers — with full backwards-compatibility guarantees, unlike .internal..
As discussed in 4/23 java SIG, ApiUsageLogger from #8318 is an early candidate for this.
Others potential candidates:
Options considered:
Classes in .impl. packages must include standard javadoc boilerplate: