fix: various custom operator conformance fixes#1778
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements to the flagd core evaluation logic, including enhanced type handling for context values, more robust SemVer parsing with support for partial versions and numeric coercion, and fixes for fractional evaluation edge cases. I have provided a suggestion to optimize the fractional evaluation logic by using List operations instead of manual array copying to improve performance.
toddbaert
force-pushed
the
chore/update-test-harness
branch
from
7c5c7cd to
6977314
Compare
toddbaert
changed the title
toddbaert
force-pushed
the
chore/update-test-harness
branch
5 times, most recently
from
6f64b40 to
d7c20b4
Compare
toddbaert
requested review from
aepfli,
alexandraoberaigner,
chrfwow,
guidobrei and
liran2000
and removed request for
Kavindu-Dodan
aepfli
approved these changes
Apr 24, 2026
chrfwow
approved these changes
Apr 27, 2026
* support v/V prefix in semver * support partial versions in semver * support numeric context values in semver * return null on errors * fix fractional single-entry flattening Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
chore/update-test-harness
branch
from
0c7570a to
23abf5a
Compare
toddbaert
added a commit
to open-feature/flagd
that referenced
this pull request
Apr 30, 2026
* support V prefix in semver * return null on errors in semver, ends_with, and fractional (already existed on starts_with) * fix fractional fallback when total weight is zero Fixes: #1942 --- Related: * open-feature/java-sdk-contrib#1778 * open-feature/js-sdk-contrib#1519 * open-feature/dotnet-sdk-contrib#635 * open-feature/python-sdk-contrib#386 --------- Signed-off-by: Lea Konvalinka <lea.konvalinka@dynatrace.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: various custom operator conformance fixes
Fixes: #1774
Related: