Conversation
Fil
commented
Aug 9, 2022
| return [name, scale === undefined ? value : map(value, scale)]; | ||
| return [ | ||
| name, | ||
| scale === undefined ? value : map(value, scale, ["x", "y", "r"].includes(scaleName) ? Float64Array : undefined) |
Contributor
Author
There was a problem hiding this comment.
TBD: this is possibly wrong, since in the case of numbers we want to wrap the scale function and return NaN when the result is null? Or maybe it never happens?
mbostock
reviewed
Aug 9, 2022
| // instanceof the desired array type, the faster values.map method is used. | ||
| export function map(values, f, type = Array) { | ||
| return values instanceof type ? values.map(f) : type.from(values, f); | ||
| if (values instanceof type) return values.map(f); |
Member
There was a problem hiding this comment.
Do we know that values is an array here? It could be that we are using map for non-arrays like iterables and {length} objects too.
…nt with the tests in the ts-options branch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's faster to allocate a typed array with a known size than through Array.from — when dealing with millions of points, this can boost the performance quite a bit.
(results of a pairing session with @yurivish)
saving as draft for now (we'll want to make the test on the scale type less ad-hoc, probably?)
see also #888