Fix SQL baseline for Parameter_collection_Concat_column_collection test#3819
Merged
roji merged 1 commit intohotfix/9.0.5from Apr 26, 2026
Merged
Fix SQL baseline for Parameter_collection_Concat_column_collection test#3819roji merged 1 commit intohotfix/9.0.5from
roji merged 1 commit intohotfix/9.0.5from
Conversation
Update the expected parameter name from @__ints_0 to @__p_0 in the AssertSql baseline for the Parameter_collection_Concat_column_collection test, matching the actual SQL generated by EF Core. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Npgsql provider’s SQL assertion baseline to match the upstream EF Core test change, fixing a CI failure on hotfix/9.0.5.
Changes:
- Updated the
AssertSqlbaseline inParameter_collection_Concat_column_collectionto use the new parameter name (@__p_0) instead of the old one (@__ints_0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the CI failure on
hotfix/9.0.5by updating theAssertSqlbaseline inParameter_collection_Concat_column_collection.The expected parameter name changed from
@__ints_0to@__p_0in the EF Core base test, but the baseline in EFCore.PG wasn't updated to match.Fixes the test failure seen in https://github.com/npgsql/efcore.pg/actions/runs/24957846612