fix: reset invalid HTTP/2 sessions#5310
Open
mcollina wants to merge 2 commits into
Open
Conversation
mcollina
force-pushed
the
fix/h2-invalid-session-reset
branch
from
f06dad1 to
8372e6f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5310 +/- ##
==========================================
- Coverage 93.23% 93.22% -0.01%
==========================================
Files 110 110
Lines 36599 36636 +37
==========================================
+ Hits 34122 34155 +33
- Misses 2477 2481 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcollina
force-pushed
the
fix/h2-invalid-session-reset
branch
from
8372e6f to
209d424
Compare
trivikr
reviewed
May 18, 2026
| } = require('../lib/core/symbols') | ||
|
|
||
| test('invalid HTTP/2 session is reset instead of throwing', async (t) => { | ||
| t = tspl(t, { plan: 10 }) |
Member
There was a problem hiding this comment.
Should we reduce usage of tspl since node 20+ has t.plan?
| return session | ||
| } | ||
|
|
||
| after(() => { |
mcollina
force-pushed
the
fix/h2-invalid-session-reset
branch
from
209d424 to
939084a
Compare
mcollina
force-pushed
the
fix/h2-invalid-session-reset
branch
from
939084a to
384612e
Compare
metcoder95
approved these changes
May 19, 2026
Member
|
lint seems unhappy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.request()throwsERR_HTTP2_INVALID_SESSIONTests
npx borp -p "test/http2-invalid-session.js"npx borp -p "test/http2-invalid-connection-headers.js"npx borp -p "test/http2-*.js"npm run lint -- test/http2-invalid-session.js lib/dispatcher/client-h2.js