fix: validate ReadableStream.from iterator objects#62911
Open
daeyeon wants to merge 1 commit intonodejs:mainfrom
Open
fix: validate ReadableStream.from iterator objects#62911daeyeon wants to merge 1 commit intonodejs:mainfrom
daeyeon wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Member
|
@daeyeon can you add a specific regression test? |
KhafraDev
reviewed
Apr 23, 2026
fd2ff95 to
147a305
Compare
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
147a305 to
e3f0af4
Compare
Member
Author
|
@panva Added a test too. PTAL when you have a chance. |
panva
approved these changes
Apr 23, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62911 +/- ##
==========================================
+ Coverage 89.62% 89.63% +0.01%
==========================================
Files 706 706
Lines 219203 219206 +3
Branches 41996 42001 +5
==========================================
+ Hits 196454 196482 +28
+ Misses 14658 14621 -37
- Partials 8091 8103 +12
🚀 New features to boost your workflow:
|
KhafraDev
approved these changes
Apr 23, 2026
MattiasBuelens
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores validation in
ReadableStream.from()so that it throws when the iterator method returns a non-object.From the spec: