Open
Conversation
Contributor
Author
|
Can verify on my fork directly: https://github.com/Dreamsorcerer/llhttp/blob/main/LICENSE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The license file is not quite correct and Github doesn't detect it properly.
Compare for example https://github.com/aio-libs/aiohttp-admin/blob/master/LICENSE
Here you'll see a banner across the top of the page, and back on the README you'll find a tab with the license there, along with the license appearing in the sidebar.
Having the correct license file is important to generate accurate SBOMs in upstream projects and verify license compliance. This should also be relevant to Node.js and any other projects that depend on llhttp.