[refactor] Use Path instead of os #19
Conversation
|
Thank you again for taking the time to submit this PR. It’s much appreciated! Could you please remove the On the technical side, switching to I need to review the logic in depth and potentially write a few more test scripts. Since this function is used for almost all the core functionality, the current test coverage isn't quite high enough to merge this blindly. I’ll aim to get this merged (without the Regards! |
|
Ok, I'll remove that file :) if you prefer, I can write tests for that function. [Update] |
|
Thanks again for this great work! It really inspired me to perform an in-depth review of the current code and evaluate the merge. Unfortunately, I have decided not to merge this PR, as the proposed changes to the Your proposed version has full path traversal, which should be avoided.
I am also concerned that these changes might break current logic on Windows and for the WASM version, especially as the testing on Windows is not yet optimally organised. Your PR inspired me to add some extra unit tests so improvements to this function can be made when needed in the future. Regards! |
ostoPathuse.collect_python_source_filesfunction to be simpler