Scale uncertainty intervals if relative = TRUE for B and SB plots#230
Merged
Schiano-NOAA merged 18 commits intodevfrom May 1, 2026
Merged
Scale uncertainty intervals if relative = TRUE for B and SB plots#230Schiano-NOAA merged 18 commits intodevfrom
Schiano-NOAA merged 18 commits intodevfrom
Conversation
Schiano-NOAA
requested changes
Apr 13, 2026
Collaborator
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
There was a problem hiding this comment.
Putting this on halt until we can talk to the steering committee and also incorporate the calcs for error here
* initial commit of new obs v pred plot * adjust process data so it converts all indexed data to character to function even when input values are numeric per #212 * update plot indices to use new plot_obsvpred function and adjust based on needs * update documentation for package * adjust plot_indices where nfleet = 1 and update test to remove new file produced * add missing dependency
…B and SB plots
Collaborator
|
@sbreitbart-NOAA can you review this? 😄 |
sbreitbart-NOAA
commented
May 1, 2026
| prepared_data <- filter_data( | ||
| dat = dat, | ||
| label_name = "^biomass$", | ||
| label_name = ifelse(relative, "biomass_biomass_unfished|biomass_ratio", "^biomass$"), # what exactly is biomass_ratio? |
Collaborator
Author
There was a problem hiding this comment.
Did you find out what biomass_ratio is? 😄
sbreitbart-NOAA
commented
May 1, 2026
sbreitbart-NOAA
commented
May 1, 2026
Collaborator
Author
|
Looks good to me! Thanks for updating those csvs 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #218