NI-RFSG Fix gRPC metadata name mismatches#2136
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
+ Coverage 81.72% 89.18% +7.45%
==========================================
Files 29 71 +42
Lines 4115 18960 +14845
==========================================
+ Hits 3363 16909 +13546
- Misses 752 2051 +1299
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Please look at the codecov results. Coverage should go up not down! |
This was probably just the result of not all system tests having run, at the time. It seems fixed, now. |
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Updates NI-RFSG function metadata to prepare for upcoming gRPC support:
grpc_namefield where is a mismatch between expected gRPC parameter name and python name.grpc_enumfield where is a mismatch between expected gRPC enum name and python enum name.These changes are needed because
ni/grpc-devicehas already shipped with these parameter and enum names, and we can’t change them without breaking the API. Also the mismatch comes from us expanding the parameter/enum names when adding them to python API metadata.List issues fixed by this Pull Request
None
What testing has been done?
gRPC related fields in RFSG metadata are not consumed in the builds yet. These changes are prerequisite to allow us to enable gRPC codegen in upcoming PRs.