Skip to content

Update last/* modules to LAST 1651 and Samtools 1.23.1#11690

Merged
SPPearce merged 6 commits into
masterfrom
last-update-202605
May 19, 2026
Merged

Update last/* modules to LAST 1651 and Samtools 1.23.1#11690
SPPearce merged 6 commits into
masterfrom
last-update-202605

Conversation

@charles-plessy
Copy link
Copy Markdown
Contributor

@charles-plessy charles-plessy commented May 19, 2026

This PR updates LAST to version 1651 and Samtools to 1.23.1, and refreshes the snaps accordingly.

In addition, it:

  • removes a temporary workaround related to earlier versions of Samtools always connecting to the EBI when opening a CRAM files;
  • allows CRAM version 3.1 now that the bam plugin of nf-test supports it;
  • passes --reference to samtools sort if the CRAM header does not provide an appropriate path to a local file (because samtools became stricter about that).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@SPPearce SPPearce added this pull request to the merge queue May 19, 2026
Merged via the queue into master with commit e972519 May 19, 2026
68 checks passed
@SPPearce SPPearce deleted the last-update-202605 branch May 19, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants