New module: octopusv/merge#11617
Open
manascripts wants to merge 7 commits into
Open
Conversation
manascripts
force-pushed
the
octopusv-merge
branch
from
ea06d22 to
f83dbf8
Compare
SPPearce
reviewed
May 18, 2026
Comment on lines
+27
to
+29
| if (explicit_flags.size() > 1) { | ||
| error("OCTOPUSV_MERGE: multiple merge strategies specified: ${explicit_flags.join(', ')}") | ||
| } |
Contributor
There was a problem hiding this comment.
I think the strategy_flag should probably be being passed as an explicit input channel to the module here.
It requires exactly one, and is necessary for the tool to run.
You can set the default if no flag is set to be union when passed via an input channel
SPPearce
reviewed
May 18, 2026
| } | ||
|
|
||
| """ | ||
| octopusv merge -i ${svcfs.join(' ')} \\ |
Contributor
There was a problem hiding this comment.
The default for Nextflow is to join inputs with a space.
Suggested change
| octopusv merge -i ${svcfs.join(' ')} \\ | |
| octopusv merge \\ | |
| -i ${svcfs} \\ |
SPPearce
requested changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #11516
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda