Update salsa2: topic versions, stub block, sanitizeOutput#11445
Merged
Conversation
SPPearce
requested changes
May 1, 2026
Contributor
SPPearce
left a comment
SPPearce
left a comment
There was a problem hiding this comment.
Use val when explicitly setting a version string, not eval.
| tuple val(meta), path("*_scaffolds_FINAL.agp") , emit: agp | ||
| tuple val(meta), path("*/*scaffolds_FINAL.original-coordinates.agp"), emit: agp_original_coordinates, optional: true | ||
| path "versions.yml" , emit: versions | ||
| tuple val("${task.process}"), val('salsa2'), eval("echo 2.3"), topic: versions, emit: versions_salsa2 |
Contributor
There was a problem hiding this comment.
Suggested change
| tuple val("${task.process}"), val('salsa2'), eval("echo 2.3"), topic: versions, emit: versions_salsa2 | |
| tuple val("${task.process}"), val('salsa2'), val("2.3"), topic: versions, emit: versions_salsa2 |
HReed1
force-pushed
the
stub-topics-salsa2
branch
from
a78d9e1 to
30d3fe6
Compare
Contributor
Author
|
@SPPearce — Great catch on that! Changed the hardcoded version string to correctly use I also rebuilt the branch cleanly from |
SPPearce
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
--profile docker,wavetests.nf-core modules lint).nf-test test).Description of changes
Migrates the salsa2 module to the nf-core v4.0.1 architecture:
versions.ymlemission with dynamiceval()tuple emission on thetopic: versionschannel. Note:salsa2does not expose a CLI version flag, so the version is hardcoded viaeval("echo 2.3")— consistent with existing upstream convention.stub:block for CI/CD stub-run support.sanitizeOutput(process.out)per nf-test best practices.output: versions_salsa2andtopics: versionssections.Part of the v4.0.1 standardization effort tracked in #11323.
Part of #4570