[stable33] fix: allow renaming files with just update permissions

[backportbot]

Backport of #57374

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

• Review and resolve any conflicts
• Review and verify the backported changes
• Remove all the empty commits

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[icewind1991]

/compile

[szaimen]

🐘

[oleksandr-nc]

❤️❤️❤️

[saw-jan]

This breaks the existing usage of DavUtil::getDavPermissions(...) in other apps
Example in https://github.com/nextcloud/integration_openproject/blob/253c6d0d1b8ba4c8ea0bd965ba7442c2117efbfe/lib/Controller/FilesController.php#L293

App will work fine with NC 33.0.1, but after upgrade to future version NC 33.0.2 (includes this changes), app will fail.

{
  "ocs": {
    "meta": {
      "status":"failure",
      "statuscode":996,
      "message":"Internal Server Error\nToo few arguments to function OCP\\Files\\DavUtil::getDavPermissions(), 1 passed in \/var\/www\/html\/custom_apps\/integration_openproject\/lib\/Controller\/FilesController.php on line 293 and exactly 2 expected in file '\/var\/www\/html\/lib\/public\/Files\/DavUtil.php' line 37",
      "totalitems":"",
      "itemsperpage":""
    },
  "data":[]
  }
}

upgrading in patch level breaks the code.

[susnux]

API break

[icewind1991]

Made the new param optional

[icewind1991]

/compile

[DaphneMuller]

The only thing left to do is checking if the tests are related. @oleksandr-nc is this something you could already briefly verify? You can then ping @sorbaugh to force merge.

[saw-jan]

Will the compatible code be ported to master? ref: #57374

[Altahrim]

/compile rebase

[oleksandr-nc]

Looks like this needs another rebase 😢

[Altahrim]

/compile rebase

[saw-jan]

@icewind1991 Is there any plan/chance that the making of parent param optional will go to the master branch (NC34) as well?

+ public static function getDavPermissions(FileInfo $info, ?FileInfo $parent = null): string {

[oleksandr-nc]

Tested this PR - it is good.
@icewind1991 , if you could rebase the PR - it would be great.
I can take a look after rebase at the failing tests, if needed.

[AndyScherzinger]

/compile

[Altahrim]

/compile amend-rebase