fix: provide required file parent param by saw-jan · Pull Request #1022 · nextcloud/integration_openproject

saw-jan · 2026-05-18T10:09:12Z

Description

Port PR #1017
Nextcloud 33: nextcloud/server#59241

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Updated CHANGELOG.md file

* fix: provide required file parent param Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * fix: use provided single nextcloud version as latest Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * fix: use method signature based on NC version Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * fix: php code style Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix API tests Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * chore: fix return type Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix test version expectation Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * ci: check server ready first Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> --------- Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

github-actions · 2026-05-18T10:22:19Z

JS Code Coverage

Coverage after merging port/pr-1017 into release/3.0 will be

92.27%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
bootstrap.js	0%	0%	0%	0%	1, 1, 10–12, 2–9
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
reference.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
utils.js	85.92%	33.33%	50%	87.59%	12–20, 23–32
src/api
endpoints.js	100%	100%	100%	100%
settings.js	64.71%	100%	0%	73.33%	10–11, 14–15
src/components
AdminSettings.vue	96.06%	94.74%	97.10%	96.19%	1003–1005, 1025–1028, 568, 568–569, 569, 606–612, 715–716, 720–721, 724–725, 729–730, 740–745, 788–790, 802–805, 818–820, 842–844, 927–929, 964–967
ErrorLabel.vue	100%	100%	100%	100%
OAuthConnectButton.vue	85.82%	63.64%	100%	87.39%	49–56, 64–69, 72–76
PersonalSettings.vue	92.02%	95.65%	90%	91.71%	133–134, 144–149, 152–161
src/components/admin
FieldValue.vue	100%	100%	100%	100%
FormAuthMethod.vue	98.12%	96.88%	100%	98.12%	222–224, 247–250
FormHeading.vue	100%	100%	100%	100%
FormOpenProjectHost.vue	98.87%	94.74%	100%	99.34%	167–169, 279
FormSSOSettings.vue	98.57%	97.18%	96.55%	98.91%	231–233, 242–243, 358–359
TermsOfServiceUnsigned.vue	100%	100%	100%	100%
TextInput.vue	100%	100%	100%	100%
src/components/icons
ClippyIcon.vue	100%	100%	100%	100%
OpenProjectIcon.vue	100%	100%	100%	100%
src/components/settings
CheckBox.vue	100%	100%	100%	100%
ErrorNote.vue	100%	100%	100%	100%
SettingsTitle.vue	94.74%	80%	100%	95.35%	49–53
src/components/tab
EmptyContent.vue	97.46%	90.48%	100%	98.24%	107–111
SearchInput.vue	95.31%	92.96%	94.74%	95.78%	138–139, 192, 203–208, 267–269, 285–287, 291–296
WorkPackage.vue	86.25%	73.17%	93.33%	87.62%	107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
appID.js	100%	100%	100%	100%
links.js	100%	100%	100%	100%
messages.js	100%	100%	100%	100%
src/filesPlugin
filesPlugin.js	0%	0%	0%	0%	1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
workpackageHelper.js	89.84%	82.14%	88.89%	92.15%	100–102, 156–157, 23–27, 34, 34, 36, 36, 50–52, 54, 54, 54–56, 97–99
src/views
CreateWorkPackageModal.vue	94.14%	86.32%	90.48%	95.40%	366–371, 374, 390, 507–510, 515–520, 525–530, 536–539, 542, 558, 558, 599–603, 613–615, 638–639, 647–649, 678–680, 702–704, 713–717
Dashboard.vue	92.96%	92.86%	82.61%	93.77%	120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
LinkMultipleFilesModal.vue	99.14%	97.56%	100%	99.32%	157–159
ProjectsTab.vue	94.95%	94.34%	93.75%	95.10%	104–107, 143, 154–155, 189–199, 248–250

github-actions · 2026-05-18T10:25:41Z

PHP Code Coverage

Coverage after merging port/pr-1017 into release/3.0 will be

66.70%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
integration_openproject/server/apps/integration_openproject/lib
Capabilities.php	0%	100%	0%	0%	24, 31–40
OIDCClientMapper.php	0%	100%	0%	0%	29, 40–49, 52
ServerVersion.php	0%	100%	0%	0%	17, 27–29, 32, 41–42
TokenEventFactory.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
Application.php	36.59%	100%	50%	35.53%	105–107, 110–114, 116–121, 123–124, 127, 132–133, 135–138, 140, 142, 144, 148–151, 153–164, 166, 169, 173, 177–179, 212
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
ConfigController.php	75.12%	100%	64.71%	75.56%	114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 541–543, 577–581, 592, 606–609, 617, 621–624, 660, 663–678, 695–700, 702–703, 705–707, 710, 712–728, 742–745, 747–751
DirectDownloadController.php	0%	100%	0%	0%	33–35, 50–52, 54–61
DirectUploadController.php	71.03%	100%	100%	70.21%	117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
FilesController.php	85.60%	100%	83.33%	85.71%	181–182, 244, 253, 270–273, 278–280, 285–287, 299, 301, 304
OpenProjectAPIController.php	80.51%	100%	82.35%	80.34%	107, 146, 193–195, 198–205, 207–211, 213, 232, 257, 322, 372, 392, 439, 464–466, 469–473, 475, 66
OpenProjectController.php	96.45%	100%	80%	96.95%	241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
OpenprojectAvatarErrorException.php	100%	100%	100%	100%
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	21
integration_openproject/server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	100%	100%	100%	100%
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
BeforeUserDeletedListener.php	0%	100%	0%	0%	30, 37–38, 40–43, 45
LoadAdditionalScriptsListener.php	0%	100%	0%	0%	37–38, 46–47, 49, 51–52, 54
LoadSidebarScript.php	65.91%	100%	100%	64.29%	105, 77–88, 95, 98
OpenProjectReferenceListener.php	0%	100%	0%	0%	45–47, 54–55, 57, 59–60, 62–74
TermsOfServiceEventListener.php	0%	100%	0%	0%	41–42, 47–48, 50–51, 53–55, 58–62
UserChangedListener.php	0%	100%	0%	0%	34, 41–42, 45–50, 53
integration_openproject/server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	30, 40–48, 50–58, 60–62, 64
Version20100Date20250820101358.php	0%	100%	0%	0%	38, 47–53, 56
Version2310Date20230116153411.php	0%	100%	0%	0%	29, 32–35, 37–62, 64–65, 67
Version2400Date20230504144300.php	0%	100%	0%	0%	30, 40–43
Version2640Date20240628114301.php	0%	100%	0%	0%	35, 47–49, 52–53, 56
Version2900Date20250718065820.php	0%	100%	0%	0%	22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
WorkPackageReferenceProvider.php	51.67%	100%	25%	58.33%	100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/Service
DatabaseService.php	42.31%	100%	60%	40.43%	108–112, 114, 63–76, 78–85
DirectDownloadService.php	88.46%	100%	100%	87.50%	62–63, 65
DirectUploadService.php	42.86%	100%	66.67%	40%	101, 62–65, 67–75, 95
OauthService.php	0%	100%	0%	0%	100–101, 40–42, 51–58,

saw-jan self-assigned this May 18, 2026

saw-jan requested review from Kharonus, NobodysNightmare, ba1ash, dominic-braeunlein, individual-it, julien-nc, lindenthal, nabim777, psatyal and wielinde as code owners May 18, 2026 10:09

saw-jan changed the title ~~fix: provide required file parent param (#1017)~~ fix: provide required file parent param May 18, 2026

ci: check proper version number

6e7cbf1

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

nabim777 approved these changes May 18, 2026

View reviewed changes

saw-jan merged commit b57a987 into release/3.0 May 18, 2026
8 of 9 checks passed

saw-jan deleted the port/pr-1017 branch May 18, 2026 10:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: provide required file parent param#1022

fix: provide required file parent param#1022
saw-jan merged 2 commits into
release/3.0from
port/pr-1017

saw-jan commented May 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

saw-jan commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

github-actions Bot commented May 18, 2026

JS Code Coverage

Uh oh!

github-actions Bot commented May 18, 2026

PHP Code Coverage

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saw-jan commented May 18, 2026 •

edited

Loading