Skip to content

feature add deck to user_migration#7870

Open
samin-z wants to merge 7 commits intomainfrom
feature/3828-user-migration-add-deck
Open

feature add deck to user_migration#7870
samin-z wants to merge 7 commits intomainfrom
feature/3828-user-migration-add-deck

Conversation

@samin-z
Copy link
Copy Markdown
Contributor

@samin-z samin-z commented Apr 20, 2026 •
edited
Loading

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96075 was 93102 (+3.19%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@samin-z samin-z force-pushed the feature/3828-user-migration-add-deck branch from bc854f8 to bcada52 Compare April 21, 2026 09:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95997 was 93102 (+3.1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96068 was 93102 (+3.18%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96065 was 93102 (+3.18%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95976 was 93102 (+3.08%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95990 was 93102 (+3.1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96818 was 93102 (+3.99%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96831 was 93102 (+4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

samin-z added 7 commits April 27, 2026 13:37
@samin-z
add deck to user migration
e344f6e 
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
move importattachment / pipeline fixes
b6a25e1 
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
update attachment and comments
f5c02df 
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
list and DeckMigrator test fixes
ca2bec7 
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
small improvement and moving AttachmentService logic
5e524ab 
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
update deckMigrator to use existing functionality of deck export
723b402 
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
optimize deck migration export queries
853c070 
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z samin-z force-pushed the feature/3828-user-migration-add-deck branch from 78208cb to 853c070 Compare April 27, 2026 11:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96828 was 93102 (+4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

grnd-alt
grnd-alt approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small questions, but nothing blocking. Nice 🥳

Comment thread lib/UserMigration/DeckMigrator.php
return $exportData;
}

private function serializeBoard(object $board, string $uid): array {
Copy link
Copy Markdown
Member

@grnd-alt grnd-alt Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this serializeBoard path, mainly exists to get comments into cards right?

Copy link
Copy Markdown
Contributor Author

@samin-z samin-z Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Comment thread lib/UserMigration/DeckMigrator.php
}

private function shouldImport(IImportSource $importSource): bool {
return $importSource->getMigratorVersion($this->getId()) !== null;
Copy link
Copy Markdown
Member

@grnd-alt grnd-alt Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any version is fine?

Copy link
Copy Markdown
Contributor Author

@samin-z samin-z Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, its just to check there is a version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samin-z @grnd-alt