fix: use _location instead of location in XMLParseError raised by visit_import#1490
Open
pauloxnet wants to merge 1 commit intomvantellingen:mainfrom
Open
fix: use _location instead of location in XMLParseError raised by visit_import#1490pauloxnet wants to merge 1 commit intomvantellingen:mainfrom
pauloxnet wants to merge 1 commit intomvantellingen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In visit_import, the XMLParseError raised when a no-namespace schema tries to import without an explicit namespace attribute passes self.document.location as the filename. SchemaDocument stores the path in _location though, so hitting this branch raises an AttributeError instead of the intended error, hiding the real problem.
One-character fix. I ran into this debugging a WCF WSDL that triggered the exact code path; without this patch the exception handler itself crashes before reporting anything useful.
The branch is only reached with unusual XSD patterns (a schema with no targetNamespace importing another no-namespace schema), which is probably why it went unnoticed.