Enable flake8-logging-format (G) linting rules via Ruff#5930
Merged
suhaibmujahid merged 13 commits intomozilla:masterfrom May 5, 2026
Merged
Enable flake8-logging-format (G) linting rules via Ruff#5930suhaibmujahid merged 13 commits intomozilla:masterfrom
suhaibmujahid merged 13 commits intomozilla:masterfrom
Conversation
suhaibmujahid
requested changes
Apr 11, 2026
Member
suhaibmujahid
left a comment
There was a problem hiding this comment.
Thank you! Please fix the failing linting errors. Installing pre-commit will allow you to test that locally.
BTW. The PR enables all flake8-logging-format (G) rules, but this is fine. I will update the PR title to reflect that.
suhaibmujahid
requested changes
Apr 20, 2026
Member
suhaibmujahid
left a comment
There was a problem hiding this comment.
@uvindusl the lint task is still failing. Could you please fix it so we can merge this PR?
Also, consider running pre-commit locally; it'll help you catch errors faster instead of waiting on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue #5792 by enabling and fixing violations of the Ruff lint rule G004 (logging-f-string). f-strings in logger calls have been replaced with lazy %-style formatting to improve performance and adhere to Mozilla's logging standards.
Changes