Skip to content

[RS] Run maintenance after each sync#7342

Queued
issammani wants to merge 7 commits intomainfrom
fix/add-vaccum-to-rs
Queued

[RS] Run maintenance after each sync#7342
issammani wants to merge 7 commits intomainfrom
fix/add-vaccum-to-rs

Conversation

@issammani
Copy link
Copy Markdown
Contributor

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@issammani issammani requested review from bendk and jonalmeida April 28, 2026 14:51
Copy link
Copy Markdown
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thanks for fixing this.

Copy link
Copy Markdown
Collaborator

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ we will need client-side patches for iOS and Android to execute this I think, but can get there easily since we've done this before and we don't have breaking API changes here.

@bendk
Copy link
Copy Markdown
Contributor

bendk commented Apr 28, 2026

r+ we will need client-side patches for iOS and Android to execute this I think, but can get there easily since we've done this before and we don't have breaking API changes here.

I think the mobile clients are already calling RemoteSettingsService::sync() which means they'll get this automatically. So we should double check that for sure, but maybe we don't need to land any other patches.

@issammani
Copy link
Copy Markdown
Contributor Author

r+ we will need client-side patches for iOS and Android to execute this I think, but can get there easily since we've done this before and we don't have breaking API changes here.

I think the mobile clients are already calling RemoteSettingsService::sync() which means they'll get this automatically. So we should double check that for sure, but maybe we don't need to land any other patches.

In the worst case scenario, we will run the sync one day after the fix lands. This should be enough.

@bendk bendk enabled auto-merge April 28, 2026 17:03
@issammani issammani force-pushed the fix/add-vaccum-to-rs branch from 8cab99d to b396de2 Compare April 28, 2026 17:16
@bendk bendk added this pull request to the merge queue Apr 28, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants