Bug 2034602 - Call unenrollForGeckoPref and getPreviousGeckoPrefStates on background thread only [ci full]#7338
Open
freshstrangemusic wants to merge 1 commit intomainfrom
Open
Conversation
4abd891 to
0cd0aae
Compare
jeddai
approved these changes
Apr 23, 2026
…s on background thread only These Nimbus client functions must only be called on the background thread because they are not thread-safe. They have been refactored into `...OnThisThread` helpers (that are private but otherwise available for testing) and have been replaced by versions that call the thread-unsafe version on the correct thread.
0cd0aae to
a482958
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These Nimbus client functions must only be called on the background thread because they are not thread-safe. They have been refactored into
...OnThisThreadhelpers (that are private but otherwise available for testing) and have been replaced by versions that call the thread-unsafe version on the correct thread.Pull Request checklist
[ci full]to the PR title.