Skip to content

Bug 2034602 - Call unenrollForGeckoPref and getPreviousGeckoPrefStates on background thread only [ci full]#7338

Open
freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic/push-nxtkmsotmnvy
Open

Bug 2034602 - Call unenrollForGeckoPref and getPreviousGeckoPrefStates on background thread only [ci full]#7338
freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic/push-nxtkmsotmnvy

Conversation

@freshstrangemusic
Copy link
Copy Markdown
Member

These Nimbus client functions must only be called on the background thread because they are not thread-safe. They have been refactored into ...OnThisThread helpers (that are private but otherwise available for testing) and have been replaced by versions that call the thread-unsafe version on the correct thread.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@freshstrangemusic freshstrangemusic changed the title Bug 2034602 - Call unenrollForGeckoPref and getPreviousGeckoPrefStates on background thread only Bug 2034602 - Call unenrollForGeckoPref and getPreviousGeckoPrefStates on background thread only [ci full] Apr 23, 2026
@freshstrangemusic freshstrangemusic force-pushed the freshstrangemusic/push-nxtkmsotmnvy branch from 4abd891 to 0cd0aae Compare April 23, 2026 19:35
Base automatically changed from freshstrangemusic/push-kmsxuspooqku to main April 28, 2026 14:39
…s on background thread only

These Nimbus client functions must only be called on the background
thread because they are not thread-safe. They have been refactored into
`...OnThisThread` helpers (that are private but otherwise available for
testing) and have been replaced by versions that call the thread-unsafe
version on the correct thread.
@freshstrangemusic freshstrangemusic force-pushed the freshstrangemusic/push-nxtkmsotmnvy branch from 0cd0aae to a482958 Compare April 29, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants