LimitSolutions: prevent child compute calls after max_solutions is reached

[DaniGarciaLopez]

Currently, when max_solutions is reached, the child may still continue computing additional solutions. This was not an issue with a simple Generator stage, but with a large SerialContainer with multiple nested stages, the computational cost becomes significant.

Moreover, these additional solutions are not propagated, since the limit for forwarding solutions has already been reached. Thus, this extra computation is wasted.

With the change proposed in this PR, once the limit of forwarded solutions (max_solutions) is reached, the child container will stop generating further solutions.

For future reference, as discussed here, a better approach might be to relax the max_solutions restriction and allow incremental forwarding of solutions, before the task fails. While limiting solutions helps reduce combinatorial explosion in long tasks, it also risks missing valid alternatives. @rhaschke Do you see a simple way—without major refactoring—to achieve this using the current wrapper implementation?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.76%. Comparing base (a7e3961) to head (410d305).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   52.89%   52.76%   -0.13%     
==========================================
  Files         138      138              
  Lines       10641    11288     +647     
  Branches     1128     1128              
==========================================
+ Hits         5628     5955     +327     
- Misses       5005     5325     +320     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rhaschke]

In general looks good. I think the two last checks for forwarded_solutions < max_solutions are redundant and can be dropped - forwarded_solutions doesn't change in between, does it?

[rhaschke]

For future reference, as discussed here, a better approach might be to allow incremental forwarding of solutions. @rhaschke Do you see a simple way—without major refactoring—to achieve this using the current wrapper implementation?

No, the wrapper approach here, doesn't allow for this solution either.

[rhaschke]

Thanks.