Skip to content

Make stream key (path) optional, defaulting to empty broadcast #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kixelated wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −3
Open

Make stream key (path) optional, defaulting to empty broadcast #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4714a35
Make stream key (path) optional, defaulting to empty broadcast
claude May 6, 2026
38f4a33
Simplify: drop redundant Defaults and Update null guards
claude May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/moq-output.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,17 @@ bool MoQOutput::Start()
return false;
}

server_url = obs_service_get_connect_info(service, OBS_SERVICE_CONNECT_INFO_SERVER_URL);
const char *server_value = obs_service_get_connect_info(service, OBS_SERVICE_CONNECT_INFO_SERVER_URL);
server_url = server_value ? server_value : "";
if (server_url.empty()) {
LOG_ERROR("Server URL is empty");
obs_output_signal_stop(output, OBS_OUTPUT_BAD_PATH);
return false;
}

path = obs_service_get_connect_info(service, OBS_SERVICE_CONNECT_INFO_STREAM_KEY);
// Path (broadcast name) is optional; an empty string publishes to the unnamed broadcast.
const char *path_value = obs_service_get_connect_info(service, OBS_SERVICE_CONNECT_INFO_STREAM_KEY);
path = path_value ? path_value : "";

bool found_encoder = false;
for (uint32_t idx = 0; idx < MAX_OUTPUT_VIDEO_ENCODERS; idx++) {
Expand Down
2 changes: 1 addition & 1 deletion src/moq-service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ obs_properties_t *MoQService::Properties()
// Adds properties to be modified by the UI.
// obs_property_t *obs_properties_add_text(obs_properties_t *props, const char *name, const char *desc, enum obs_text_type type)
obs_properties_add_text(ppts, "server", "URL", OBS_TEXT_DEFAULT);
obs_properties_add_text(ppts, "key", "Path", OBS_TEXT_DEFAULT);
obs_properties_add_text(ppts, "key", "Path (optional)", OBS_TEXT_DEFAULT);

return ppts;
}
Expand Down
Loading