Cmake: Cmake ffmpeg library fix for Windows#31
Cmake: Cmake ffmpeg library fix for Windows#31danrossi wants to merge 15 commits intomoq-dev:mainfrom
Conversation
- Add windows environment setup and build instructions - Update build specs to the latest obs-deps versions - Change library resolving for windows to use the pre built ffmpeg libaries - Add extra required windows libraries needed
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughCMakeLists: when 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
CMakeLists.txt (1)
25-25: ConfirmUserenv/ntdllare needed for theobs-moqtarget directly.These are almost certainly pulled in transitively by
libmoq(Rust std). Linking them againstobs-moqis harmless, but if you can confirm they come from the Rust static lib, it may be cleaner to expose them as INTERFACE link libs from themoqtarget instead of the plugin. Low priority.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CMakeLists.txt` at line 25, The CMake line linking Userenv and ntdll directly into the obs-moq target may be redundant because those libs are likely pulled in by the Rust static library (libmoq); confirm whether the transitive dependency originates from the moq target (or libmoq) and if so move Userenv and ntdll to the moq target as INTERFACE link libraries instead of linking them directly to obs-moq; check the CMake target names target_link_libraries(obs-moq ...), the moq target, and any Rust-produced static lib exports to decide whether to change the linkage to target_link_libraries(moq INTERFACE Userenv ntdll) and remove them from obs-moq.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CMakeLists.txt`:
- Around line 27-32: The find_library invocations (e.g., the calls that set
AVCODEC_LIB, AVUTIL_LIB, SWSCALE_LIB, SWRESAMPLE_LIB) are missing REQUIRED and
search hints so a missing library becomes <VAR>-NOTFOUND later; update each
find_library to use REQUIRED and provide sensible PATHS/HINTS (for example
system/library install prefixes or a build/install output directory used by your
presets) so CMake fails at configure time with a clear error if a library is
absent and so discovery falls back to the intended destination directory when
CMAKE_PREFIX_PATH isn’t set; keep target_link_libraries(obs-moq PRIVATE
${AVCODEC_LIB} ...) unchanged since it will then receive only valid library
results.
In `@WINDOWS.md`:
- Around line 5-11: The fenced code block in WINDOWS.md opens with two backticks
instead of three and lacks a language tag, causing rendering and MD040 lint
failures; change the opening fence to ```powershell and close with ```; also
make the Chocolatey installs non-interactive and consistent by adding -y to the
visualstudio2026buildtools line and replace the rustup install with the correct
choco package (rustup.install) and -y flag so the lines to update are the fenced
block around the PowerShell commands and the choco install invocations.
- Around line 33-37: Update the code fence in WINDOWS.md that contains the
Copy-Item example to include the powershell language identifier; replace the
current triple-backtick block around the Copy-Item command with an opening
"```powershell" and a closing "```" so the code block is annotated for MD040 and
tools that rely on language highlighting.
- Around line 19-23: The fenced code blocks containing the Windows shell
commands (the block with "cd obs-studio" and the cmake invocations including -G
"Visual Studio 18 2026" -A x64 --preset windows-x64 and cmake --build --preset
windows-x64) need explicit language identifiers (e.g., powershell or bat) to
satisfy MD040; update each of those code fences to include the appropriate
language tag so the snippets are properly highlighted while leaving the existing
cmake flags and preset usage unchanged.
---
Nitpick comments:
In `@CMakeLists.txt`:
- Line 25: The CMake line linking Userenv and ntdll directly into the obs-moq
target may be redundant because those libs are likely pulled in by the Rust
static library (libmoq); confirm whether the transitive dependency originates
from the moq target (or libmoq) and if so move Userenv and ntdll to the moq
target as INTERFACE link libraries instead of linking them directly to obs-moq;
check the CMake target names target_link_libraries(obs-moq ...), the moq target,
and any Rust-produced static lib exports to decide whether to change the linkage
to target_link_libraries(moq INTERFACE Userenv ntdll) and remove them from
obs-moq.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: acb0e0df-f4d3-4c00-bad3-2298ac4cd646
📒 Files selected for processing (3)
CMakeLists.txtWINDOWS.mdbuildspec.json
- add check for ffmpeg library path
There was a problem hiding this comment.
♻️ Duplicate comments (1)
CMakeLists.txt (1)
27-34:⚠️ Potential issue | 🟠 Major
find_librarycalls still lackREQUIRED/search hints, and the PR-promised destination-directory fallback is missing.The previously raised concerns still apply to this revision:
- None of the four
find_librarycalls useREQUIRED, so a missing component yields<VAR>-NOTFOUND. Theif(AVCODEC_LIB)guard at line 32 only papers over one of the four — ifavcodecis found but any ofavutil/swscale/swresampleis not, thoseNOTFOUNDvalues still flow intotarget_link_libraries, producing a confusing linker error rather than a clean configure-time failure. Given thatsrc/moq-source.cppcallsavcodec_find_decoder,avcodec_alloc_context3,sws_getContext,sws_scale, etc., none of these libraries are optional — silently skipping linkage is unsafe.- No
PATHS/HINTSare passed, so discovery depends entirely on the caller'sCMAKE_PREFIX_PATH. The PR description says this PR adds "a method to automatically search the destination directory when CMake variables are not set", but I don't see any such fallback in the diff — please confirm whether that piece was intended to land here.🛠️ Suggested fix
- find_library(AVCODEC_LIB avcodec) - find_library(AVUTIL_LIB avutil) - find_library(SWSCALE_LIB swscale) - find_library(SWRESAMPLE_LIB swresample) - - if (AVCODEC_LIB) - target_link_libraries(obs-moq PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB}) - endif() + find_library(AVCODEC_LIB avcodec REQUIRED) + find_library(AVUTIL_LIB avutil REQUIRED) + find_library(SWSCALE_LIB swscale REQUIRED) + find_library(SWRESAMPLE_LIB swresample REQUIRED) + + target_link_libraries( + obs-moq + PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB} + )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CMakeLists.txt` around lines 27 - 34, The find_library invocations for avcodec/avutil/swscale/swresample must fail at configure-time and search the build/install destination if variables are unset: change the four find_library calls (AVCODEC_LIB, AVUTIL_LIB, SWSCALE_LIB, SWRESAMPLE_LIB) to use REQUIRED and add appropriate HINTS/PATHS that include the destination-directory fallback (e.g., the project's install or output dirs or a CMake variable like DESTDIR/CMAKE_INSTALL_PREFIX) so CMake will search those locations; then remove the weak if(AVCODEC_LIB) guard and instead perform a single configure-time check (or let REQUIRED enforce it) before calling target_link_libraries(obs-moq PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB}) so no NOTFOUND values are propagated into the linker step.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@CMakeLists.txt`:
- Around line 27-34: The find_library invocations for
avcodec/avutil/swscale/swresample must fail at configure-time and search the
build/install destination if variables are unset: change the four find_library
calls (AVCODEC_LIB, AVUTIL_LIB, SWSCALE_LIB, SWRESAMPLE_LIB) to use REQUIRED and
add appropriate HINTS/PATHS that include the destination-directory fallback
(e.g., the project's install or output dirs or a CMake variable like
DESTDIR/CMAKE_INSTALL_PREFIX) so CMake will search those locations; then remove
the weak if(AVCODEC_LIB) guard and instead perform a single configure-time check
(or let REQUIRED enforce it) before calling target_link_libraries(obs-moq
PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB}) so no
NOTFOUND values are propagated into the linker step.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ad8e0cea-ddad-46b3-9578-066f9ed56b93
📒 Files selected for processing (2)
CMakeLists.txtWINDOWS.md
✅ Files skipped from review due to trivial changes (1)
- WINDOWS.md
|
I'm not sure why the bot spelt out what I just did. There is no "REQUIRED" for I'm not sure what this means it's an error "only linking to the plugin if avcodec is found" The pre-built deps are baked and already there so it will find all of them. I'll test a publish to the local relay before trying other relays inc cloudflare. |
|
Oh sorry I forgot about this PR. I'll take a look later today. |
|
I don't see an issue with my build but the plugin won't connect to either the relay in WSL or in Powershell. I was able to build a relay exe in powershell then run it directly not requiring to rebuild everytime. It consumes alot of memory and cpu when rebuilding to launch the relay. There is no way to get a rust trace log launching obs in powershell it closes stdout after launching obs. There is just the obs logger. I tried this The callback error code for the connection is -5 which might need to return a string instead from the error code ?. I see no activity in the relay of a connection. And nothing in wireshark shows up. Publishing works running the demo so the rust publisher is working. I will try and run that command separate. |
|
The web and moq-cli publish is working. To both the linux and windows relay. OBS isn't connecting for some reason and hard to debug still. I've got a mac mini to test mac. I'll test if the rust publisher works with cloudflare not just the rust relay. I wanted to test that with OBS also. |
|
The build instructions for obs-studio has changed for macos. They require to build after config in xcode and there is a code error with a trailing comma in a shader I now have to fix for them to get it built to test the plugin on mac. Will figure it out. the build instructions for mac may need to change. https://github.com/obsproject/obs-studio/wiki/build-instructions-for-mac |
|
I have a functioning branch here with moq and some fixes for mac with the current master obs branch. https://github.com/danrossi/obs-studio/tree/moq-merged mac build of obs is The mac build of the plugin however also suffers the same as windows looking for pkgconfig which is not installed by default. It may be trying to search for system files rather the included deps. I'll try and fix for mac also if needed. |
|
Installing pkg-config on mac it's a tool check for system ffmpeg libraries. I'll make a proposal change to use the included dependencies like Windows for mac and Linux. To follow the obs-studio build ? I've converted to draft. |
… in the obs dependancies
- update build docs for obs-studio
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
135-139:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win"Supported Build Environments" table is stale — still shows VS 17 2022 and Xcode 16.0.
After this PR's changes the minimum supported toolchain is VS 18 2026 (CMake 4.2+) on Windows and Xcode 16.3 on macOS, but the table retains the old values.
📝 Suggested fix
| Platform | Tool | |-----------|--------| -| Windows | Visual Studio 17 2022 | -| macOS | Xcode 16.0 | -| Windows, macOS | CMake 3.30.5 | +| Windows | Visual Studio 18 2026 | +| macOS | Xcode 16.3 | +| Windows | CMake 4.2+ | +| macOS | CMake 3.30.5 |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 135 - 139, Update the "Supported Build Environments" table in README.md to reflect the new minimum toolchains: change the Windows entry from "Visual Studio 17 2022" to "Visual Studio 18 2026", update the macOS entry from "Xcode 16.0" to "Xcode 16.3", and change the CMake entry from "CMake 3.30.5" to "CMake 4.2+" so the table under the "Supported Build Environments" heading matches the PR changes.
♻️ Duplicate comments (1)
CMakeLists.txt (1)
19-26:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
if (AVCODEC_LIB)guard only protects one of four libraries — the other three can still be*-NOTFOUND.When
AVCODEC_LIBis found but any ofAVUTIL_LIB,SWSCALE_LIB, orSWRESAMPLE_LIBare not found, their*-NOTFOUNDsentinel strings are silently forwarded totarget_link_libraries, producing a confusing linker error instead of a clear configure-time failure. AddingREQUIREDto all fourfind_librarycalls (along withHINTSfromCMAKE_PREFIX_PATH) is the idiomatic fix and eliminates the need for the manual guard entirely.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CMakeLists.txt` around lines 19 - 26, The current CMake snippet uses find_library for AVCODEC_LIB, AVUTIL_LIB, SWSCALE_LIB, and SWRESAMPLE_LIB but only guards target_link_libraries with if(AVCODEC_LIB), allowing other variables to be `*-NOTFOUND`; change each find_library(...) call to include REQUIRED and appropriate HINTS using ${CMAKE_PREFIX_PATH} (e.g. find_library(AVCODEC_LIB NAMES avcodec REQUIRED HINTS ${CMAKE_PREFIX_PATH})), do the same for AVUTIL_LIB, SWSCALE_LIB, and SWRESAMPLE_LIB, and then remove the manual if(AVCODEC_LIB) guard so target_link_libraries(obs-moq PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB}) is always passed only after configure-time failures if any library is missing.
🧹 Nitpick comments (1)
CMakeLists.txt (1)
24-24: 💤 Low valueRun
./build-aux/run-gersemi—if (AVCODEC_LIB)has a space before(inconsistent withif(OS_WINDOWS)on Line 29.As per coding guidelines, CMake files should be formatted using
./build-aux/run-gersemi.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CMakeLists.txt` at line 24, The CMake conditional "if (AVCODEC_LIB)" has an extra space before the paren and should match the project's style (e.g. "if(OS_WINDOWS)"); update the token to remove the space so it reads consistently with other conditionals and then run the formatter tool by executing ./build-aux/run-gersemi to reformat the CMakeLists; look for the "if (AVCODEC_LIB)" occurrence and update it to the no-space form used by "if(OS_WINDOWS)" and commit the formatted file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cmake/common/buildspec_common.cmake`:
- Around line 65-74: Add an existence guard before calling file(READ) for
"${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt" so CMake
won't fatal-error when the file is missing; keep the surrounding if(_obs_version
VERSION_LESS_EQUAL "32.1.2") block. Update the string(REGEX REPLACE) pattern
used to insert enable_language(Swift) to escape dots in the version tokens
(e.g., use "3\\.28...3\\.30") so it matches literal dots, and after computing
NEW_CONTENTS compare it to CONTENTS and emit a message(WARNING ...) if they are
identical (indicating the replace did nothing) rather than silently proceeding;
leave the message(STATUS "Patching libobs-metal") and file(WRITE ...) logic
unchanged but only run them when the file exists and NEW_CONTENTS differs from
CONTENTS.
In `@README.md`:
- Line 21: Update the README macOS prerequisite to match the enforced SDK
version in cmake/macos/compilerconfig.cmake: change the listed "macOS 15" to
"macOS 15.4" (and if present, any combined entry like "XCode 16.3 / macOS 15" to
"XCode 16.3 / macOS 15.4") so it aligns with the obs_macos_minimum_sdk = 15.4
setting and prevents users on 15.0–15.3 from encountering a configure-time fatal
error.
---
Outside diff comments:
In `@README.md`:
- Around line 135-139: Update the "Supported Build Environments" table in
README.md to reflect the new minimum toolchains: change the Windows entry from
"Visual Studio 17 2022" to "Visual Studio 18 2026", update the macOS entry from
"Xcode 16.0" to "Xcode 16.3", and change the CMake entry from "CMake 3.30.5" to
"CMake 4.2+" so the table under the "Supported Build Environments" heading
matches the PR changes.
---
Duplicate comments:
In `@CMakeLists.txt`:
- Around line 19-26: The current CMake snippet uses find_library for
AVCODEC_LIB, AVUTIL_LIB, SWSCALE_LIB, and SWRESAMPLE_LIB but only guards
target_link_libraries with if(AVCODEC_LIB), allowing other variables to be
`*-NOTFOUND`; change each find_library(...) call to include REQUIRED and
appropriate HINTS using ${CMAKE_PREFIX_PATH} (e.g. find_library(AVCODEC_LIB
NAMES avcodec REQUIRED HINTS ${CMAKE_PREFIX_PATH})), do the same for AVUTIL_LIB,
SWSCALE_LIB, and SWRESAMPLE_LIB, and then remove the manual if(AVCODEC_LIB)
guard so target_link_libraries(obs-moq PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB}
${SWSCALE_LIB} ${SWRESAMPLE_LIB}) is always passed only after configure-time
failures if any library is missing.
---
Nitpick comments:
In `@CMakeLists.txt`:
- Line 24: The CMake conditional "if (AVCODEC_LIB)" has an extra space before
the paren and should match the project's style (e.g. "if(OS_WINDOWS)"); update
the token to remove the space so it reads consistently with other conditionals
and then run the formatter tool by executing ./build-aux/run-gersemi to reformat
the CMakeLists; look for the "if (AVCODEC_LIB)" occurrence and update it to the
no-space form used by "if(OS_WINDOWS)" and commit the formatted file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 568d4fc6-66f5-4e81-a869-30f2ae368f29
📒 Files selected for processing (6)
CMakeLists.txtREADME.mdWINDOWS.mdbuildspec.jsoncmake/common/buildspec_common.cmakecmake/macos/compilerconfig.cmake
✅ Files skipped from review due to trivial changes (1)
- buildspec.json
🚧 Files skipped from review as they are similar to previous changes (1)
- WINDOWS.md
| if (_obs_version VERSION_LESS_EQUAL "32.1.2") | ||
|
|
||
| file(READ "${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt" CONTENTS) | ||
|
|
||
| #check if Swift is not available | ||
| if(NOT "${CONTENTS}" MATCHES "enable_language\\(Swift\\)") | ||
| string(REGEX REPLACE "cmake_minimum_required\\(VERSION 3.28...3.30\\)" "cmake_minimum_required(VERSION 3.28...3.30)\nenable_language(Swift)" NEW_CONTENTS "${CONTENTS}") | ||
| message(STATUS "Patching libobs-metal") | ||
| file(WRITE "${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt" "${NEW_CONTENTS}") | ||
| endif() |
There was a problem hiding this comment.
Add if(EXISTS ...) guard before file(READ ...) — fatal error if the path is absent.
file(READ ...) on Line 67 will abort CMake configure with an unhelpful fatal error if ${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt does not exist (e.g., partial extraction, unexpected OBS source layout, or obs-studio dependency not yet present). Add an existence check first.
🛠️ Proposed fix
- `#Patch` libobs-metal if required
- if (_obs_version VERSION_LESS_EQUAL "32.1.2")
-
- file(READ "${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt" CONTENTS)
-
- `#check` if Swift is not available
- if(NOT "${CONTENTS}" MATCHES "enable_language\\(Swift\\)")
- string(REGEX REPLACE "cmake_minimum_required\\(VERSION 3.28...3.30\\)" "cmake_minimum_required(VERSION 3.28...3.30)\nenable_language(Swift)" NEW_CONTENTS "${CONTENTS}")
- message(STATUS "Patching libobs-metal")
- file(WRITE "${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt" "${NEW_CONTENTS}")
- endif()
-
- endif()
+ # Patch libobs-metal if required
+ if(_obs_version VERSION_LESS_EQUAL "32.1.2")
+ set(_libobs_metal_cmake "${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt")
+ if(EXISTS "${_libobs_metal_cmake}")
+ file(READ "${_libobs_metal_cmake}" CONTENTS)
+ # Check if Swift is not already enabled
+ if(NOT "${CONTENTS}" MATCHES "enable_language\\(Swift\\)")
+ string(
+ REGEX REPLACE
+ "cmake_minimum_required\\(VERSION 3\\.28\\.\\.\\. ?3\\.30\\)"
+ "cmake_minimum_required(VERSION 3.28...3.30)\nenable_language(Swift)"
+ NEW_CONTENTS
+ "${CONTENTS}"
+ )
+ if(NOT NEW_CONTENTS STREQUAL CONTENTS)
+ message(STATUS "Patching libobs-metal")
+ file(WRITE "${_libobs_metal_cmake}" "${NEW_CONTENTS}")
+ else()
+ message(WARNING "libobs-metal patch: regex did not match; Swift may not be enabled")
+ endif()
+ endif()
+ else()
+ message(WARNING "libobs-metal/CMakeLists.txt not found at ${_libobs_metal_cmake}; skipping Swift patch")
+ endif()
+ endif()The proposed fix also escapes the . characters in the version range regex (e.g., 3\\.28) so they match literal dots rather than any character, and adds a guard to warn if the string(REGEX REPLACE) produces no change — which would leave Swift silently un-enabled even though the enable_language(Swift) check triggered.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmake/common/buildspec_common.cmake` around lines 65 - 74, Add an existence
guard before calling file(READ) for
"${dependencies_dir}/${_obs_destination}/libobs-metal/CMakeLists.txt" so CMake
won't fatal-error when the file is missing; keep the surrounding if(_obs_version
VERSION_LESS_EQUAL "32.1.2") block. Update the string(REGEX REPLACE) pattern
used to insert enable_language(Swift) to escape dots in the version tokens
(e.g., use "3\\.28...3\\.30") so it matches literal dots, and after computing
NEW_CONTENTS compare it to CONTENTS and emit a message(WARNING ...) if they are
identical (indicating the replace did nothing) rather than silently proceeding;
leave the message(STATUS "Patching libobs-metal") and file(WRITE ...) logic
unchanged but only run them when the file exists and NEW_CONTENTS differs from
CONTENTS.
|
There was requirements to get the mac build working. The changes required is to use the pre built libraries provided. I'll test Linux I may need to revert back to pkg-config for Linux. mac build requires Xcode 16.3 for both obs-studio and the obs-moq plugin. The build requires to patch the obs source archive to configure correctly until a change is made to the source archive. It checks for that. I've updated the obs-studio build docs for both Windows and mac. The repo for obs-studio won't have the libobs-metal fix. Which I have in this merged branch https://github.com/danrossi/obs-studio/tree/moq-merged I can test with debug flags on mac the connection issue to the relay. 
|
|
On mac I see it connecting to these interfaces when using localhost. So the mac OBS client is working to the localhost relay for now. Not Windows, I'll see if there is a way to get a trace on Windows. I have IPv6 setup on the interface. It might need to bind to 0.0.0.0 A connection issue might need to trigger an error dialog window. |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
CMakeLists.txt (1)
28-35:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFail fast for all FFmpeg libs instead of gating on
AVCODEC_LIBonly.Line 33 currently checks only
AVCODEC_LIB, while Line 34 links four libraries. If any of the other three are missing, failure is delayed/confusing. UseREQUIREDon allfind_librarycalls and remove the partial gate so configure fails clearly.#!/bin/bash set -euo pipefail echo "FFmpeg find_library calls:" rg -nP 'find_library\((AVCODEC_LIB|AVUTIL_LIB|SWSCALE_LIB|SWRESAMPLE_LIB)\b' CMakeLists.txt echo echo "Which of those use REQUIRED:" rg -nP 'find_library\((AVCODEC_LIB|AVUTIL_LIB|SWSCALE_LIB|SWRESAMPLE_LIB)\b[^\)]*REQUIRED' CMakeLists.txt || true echo echo "Current link gate and link line:" rg -nP 'if\s*\(\s*AVCODEC_LIB\s*\)|target_link_libraries\(obs-moq PRIVATE \$\{AVCODEC_LIB\}' CMakeLists.txtSuggested patch
- find_library(AVCODEC_LIB avcodec) - find_library(AVUTIL_LIB avutil) - find_library(SWSCALE_LIB swscale) - find_library(SWRESAMPLE_LIB swresample) - - if (AVCODEC_LIB) - target_link_libraries(obs-moq PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB}) - endif() + find_library(AVCODEC_LIB avcodec REQUIRED) + find_library(AVUTIL_LIB avutil REQUIRED) + find_library(SWSCALE_LIB swscale REQUIRED) + find_library(SWRESAMPLE_LIB swresample REQUIRED) + target_link_libraries(obs-moq PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB})🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CMakeLists.txt` around lines 28 - 35, The CMake snippet currently only gates linking on AVCODEC_LIB but links AVCODEC_LIB, AVUTIL_LIB, SWSCALE_LIB, and SWRESAMPLE_LIB; make all four find_library calls fail-fast by adding REQUIRED to each find_library(AVCODEC_LIB ...), find_library(AVUTIL_LIB ...), find_library(SWSCALE_LIB ...), and find_library(SWRESAMPLE_LIB ...) and remove the conditional if (AVCODEC_LIB) ... endif() so target_link_libraries(obs-moq PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB}) always runs (configuration will now error if any FFmpeg lib is missing).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cmake/macos/compilerconfig.cmake`:
- Around line 19-20: The macOS minimums are set too high; update the CMake
variables obs_macos_minimum_sdk and obs_macos_minimum_xcode in
compilerconfig.cmake to match upstream OBS baselines by setting
obs_macos_minimum_sdk to 15.0 and obs_macos_minimum_xcode to 16.0 so the
FATAL_ERROR checks use the correct, less restrictive minima.
---
Duplicate comments:
In `@CMakeLists.txt`:
- Around line 28-35: The CMake snippet currently only gates linking on
AVCODEC_LIB but links AVCODEC_LIB, AVUTIL_LIB, SWSCALE_LIB, and SWRESAMPLE_LIB;
make all four find_library calls fail-fast by adding REQUIRED to each
find_library(AVCODEC_LIB ...), find_library(AVUTIL_LIB ...),
find_library(SWSCALE_LIB ...), and find_library(SWRESAMPLE_LIB ...) and remove
the conditional if (AVCODEC_LIB) ... endif() so target_link_libraries(obs-moq
PRIVATE ${AVCODEC_LIB} ${AVUTIL_LIB} ${SWSCALE_LIB} ${SWRESAMPLE_LIB}) always
runs (configuration will now error if any FFmpeg lib is missing).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0c66aab1-2d4f-458a-8db4-8c88ff7ab59d
📒 Files selected for processing (3)
CMakeLists.txtbuildspec.jsoncmake/macos/compilerconfig.cmake
✅ Files skipped from review due to trivial changes (1)
- buildspec.json
| set(obs_macos_minimum_sdk 26.1) # Keep in sync with Xcode | ||
| set(obs_macos_minimum_xcode 26.1) # Keep in sync with SDK |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Local thresholds in this PR:"
rg -n 'set\(obs_macos_minimum_(sdk|xcode)' cmake/macos/compilerconfig.cmake
echo
echo "Upstream OBS 32.1.2 thresholds:"
curl -fsSL https://raw.githubusercontent.com/obsproject/obs-studio/32.1.2/cmake/macos/compilerconfig.cmake \
| rg -n 'set\(obs_macos_minimum_(sdk|xcode)'Repository: moq-dev/obs
Length of output: 369
26.1 macOS minimums are stricter than upstream OBS 32.1.2 baselines
Lines 19–20 set both SDK and Xcode minimums to 26.1, which is 11.1 and 10.1 versions above upstream OBS 32.1.2 (15.0 SDK, 16.0 Xcode). These values feed hard FATAL_ERROR checks and unnecessarily restrict valid build environments. This is unrelated to the PR's primary Windows FFmpeg/CMake changes.
Align with upstream by using 15.0 for SDK and 16.0 for Xcode.
Suggested fix
- set(obs_macos_minimum_sdk 26.1) # Keep in sync with Xcode
- set(obs_macos_minimum_xcode 26.1) # Keep in sync with SDK
+ set(obs_macos_minimum_sdk 15.0) # Keep in sync with Xcode
+ set(obs_macos_minimum_xcode 16.0) # Keep in sync with SDK📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| set(obs_macos_minimum_sdk 26.1) # Keep in sync with Xcode | |
| set(obs_macos_minimum_xcode 26.1) # Keep in sync with SDK | |
| set(obs_macos_minimum_sdk 15.0) # Keep in sync with Xcode | |
| set(obs_macos_minimum_xcode 16.0) # Keep in sync with SDK |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmake/macos/compilerconfig.cmake` around lines 19 - 20, The macOS minimums
are set too high; update the CMake variables obs_macos_minimum_sdk and
obs_macos_minimum_xcode in compilerconfig.cmake to match upstream OBS baselines
by setting obs_macos_minimum_sdk to 15.0 and obs_macos_minimum_xcode to 16.0 so
the FATAL_ERROR checks use the correct, less restrictive minima.
|
The minimum mac requirements is now Xcode / SDK 26.1 and mac OS 15.6 to reflect the obs-studio build workflow. Windows needs a post install script as the locale file needs to go into the data directory not the plugins directory. The mac build should be working now with the changes made I've tested it with a local relay but need to get it connected to an external relay. Still working on getting the Windows build connecting. The patch needed of the obs source archive is within the macOS platform check so the bot is not correct again. It needs to be done during the obs setup function. |
- update windows docs with configure, build and install command - update justfile with build and install command - update docs with minimum macOS requirements
|
There is a cmake install command that will install into the configured prefix path. I've updated the configs and docs for that. It goes into a common directory. Windows client for some reason wants to connect to https://localhost:4443 for both OBS and the web subscriber which then falls back to websocket for some reason. 127.0.0.1 is required for obs to connect to the relay. Will have to setup ssl certs to do a host check. I've been unable to figure out how to map internal rust logs to c logging. There is no way to get standard output running in powershell. There is a crate called obs-log but no way to connect that. A callback method is needed to get the logs to log to obs logging. |
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
WINDOWS.md (1)
9-10:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winChocolatey installs still lack
-yand therustuppackage name is incorrect.Lines 9–10 were previously flagged and marked as addressed, but the current code still has both problems:
- Neither
choco install visualstudio2026buildtoolsnorchoco install rustupcarries the-y(non-interactive) flag — both will pause for user confirmation, blocking any automated/scripted setup.rustupis not a valid Chocolatey package name; the correct package identifier isrustup.install.📝 Proposed fix
- choco install visualstudio2026buildtools --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --includeRecommended" - choco install rustup + choco install -y visualstudio2026buildtools --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --includeRecommended" + choco install -y rustup.install🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@WINDOWS.md` around lines 9 - 10, The Chocolatey install commands are blocking and use an incorrect package name: update the two lines invoking choco so they run non-interactively and use the correct Rust package — add the -y flag to "choco install visualstudio2026buildtools" and to the Rust install command, and change "choco install rustup" to "choco install rustup.install -y"; ensure you update the occurrences of visualstudio2026buildtools and rustup to these exact corrected forms so scripted setups won't pause.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@justfile`:
- Line 33: The build target in justfile currently runs cmake --build --preset
"$PRESET" --target install which unconditionally installs the plugin to the user
OBS directory and breaks local macOS testing expected by the commented run
target; either restore the previously removed copy step that copies the built
plugin into the local OBS app path (the cp that placed the plugin into
../obs-studio/build_macos/.../OBS.app/Contents/PlugIns/) or make the --target
install invocation conditional (e.g., only run when an INSTALL flag is set) so
local development uses the built artifact in the local build tree rather than
$ENV{HOME}/Library/Application Support/obs-studio/plugins.
In `@WINDOWS.md`:
- Around line 35-36: The PowerShell debug one-liner in WINDOWS.md is not inside
a fenced code block; edit the Markdown to wrap the entire command (the
PowerShell one-liner starting with $env:RUST_LOG="debug"; $env:RUST_BACKTRACE=1;
...) in a fenced block using ```powershell before the line and ``` after it so
it renders as a copyable, syntax-highlighted code snippet.
---
Duplicate comments:
In `@WINDOWS.md`:
- Around line 9-10: The Chocolatey install commands are blocking and use an
incorrect package name: update the two lines invoking choco so they run
non-interactively and use the correct Rust package — add the -y flag to "choco
install visualstudio2026buildtools" and to the Rust install command, and change
"choco install rustup" to "choco install rustup.install -y"; ensure you update
the occurrences of visualstudio2026buildtools and rustup to these exact
corrected forms so scripted setups won't pause.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2bdca1a6-fab0-4096-a24c-b257a6d27abf
📒 Files selected for processing (4)
README.mdWINDOWS.mdcmake/windows/defaults.cmakejustfile
🚧 Files skipped from review as they are similar to previous changes (1)
- README.md
|
I just managed to debug why the Windows publisher and relay keeps falling back to websocket. Even with a an SSL cert and host mapping to a static ip 192.168.x.x. Ipv6 seems to be messing it up. So while Windows OBS can't be trace logged properly the Windows rust publish I eventually got working over Git Bash shows the log. Its the same running in WSL. I'll report on the other project if there is an issue. The production config is not correct either as it requires a vect for one of the cert configs but a string for another. The bind address is a static ip 192.168.x.x. I'll see if a mac publish in OBS does the same and if it's the Windows relay although the relay would be running in Linux normally. I'll try the relay back in WSL. The publisher from WSL to a Windows relay does not fallback to websocket. So it's not an obs plugin issue but the publisher on the Windows side. |
2 participants
Thanks for doing this plugin. Yet to begin testing it. Will this work perhaps with Cloudflare Moq relay ? I have set it up on Cloudflare for testing.
I found the Windows build broken because pkg-config is resolving system libraries. It took me a few days to understand how cmake works as its really busy. This change uses the pre-built libraries already downloaded for Windows. I found a method to automatically search the destination directory as the variables dont get set for it. It needed two extra Windows libraries. The spec downloads the latest version.
I've created a windows specific build setup doc including environment tools setup. It took a while to figure that out to get obs built first. I am using VS2026 build tools so documented that setup.
There is a way to program installation into the obs fork in the windows specific cmake files but haven't figured that out yet. The location is
I have an obs fork where I've merged from the upstream branch and shows a menu for now.
https://github.com/danrossi/obs-studio/tree/moq-merged