Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors AsyncContent to expose query results as Solid accessors instead of raw values, then updates frontend call sites, stories, and tests to use the new reactive API. This fits the frontend’s SolidJS migration by making async content consumption more signal-friendly.
Changes:
- Change
AsyncContentchild props to pass accessors and add logic to retain the last resolved value during deferred loading. - Update frontend consumers (
AboutPage,LeaderboardPage,ProfilePage,Inbox,VersionHistoryModal) and Storybook stories to call returned accessors. - Adjust
AsyncContenttests to match the new accessor-based API for single and multi-query cases.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/storybook/stories/AsyncContent.stories.tsx |
Updates Storybook examples to read async values via accessors. |
frontend/src/ts/components/popups/alerts/Inbox.tsx |
Adapts inbox list rendering to the new AsyncContent child API. |
frontend/src/ts/components/pages/profile/ProfilePage.tsx |
Updates profile rendering to unwrap the async profile accessor. |
frontend/src/ts/components/pages/leaderboard/LeaderboardPage.tsx |
Refactors leaderboard consumers to read accessor-backed async query results. |
frontend/src/ts/components/pages/AboutPage.tsx |
Updates stats, charts, supporters, and contributors sections to use accessors. |
frontend/src/ts/components/modals/VersionHistoryModal.tsx |
Adjusts version history rendering for accessor-based infinite-query data. |
frontend/src/ts/components/common/AsyncContent.tsx |
Core refactor: accessor-based children plus cached last resolved value and loader behavior changes. |
frontend/__tests__/components/common/AsyncContent.spec.tsx |
Rewrites tests around the new accessor contract for AsyncContent. |
fehmer
reviewed
May 2, 2026
fehmer
reviewed
May 2, 2026
fehmer
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.