impr(languages): add Objective-C language (@damilss)#7887
Open
Damilss wants to merge 1 commit intomonkeytypegame:masterfrom
Open
impr(languages): add Objective-C language (@damilss)#7887Damilss wants to merge 1 commit intomonkeytypegame:masterfrom
Damilss wants to merge 1 commit intomonkeytypegame:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Objective-C as a selectable “code” language across the schema + frontend language grouping, backed by a new static wordlist JSON (so it can be used like the existing code_* languages).
Changes:
- Add
code_objective_cto the sharedLanguageSchemaenum. - Add
code_objective_cto the frontendLanguageGroups.codelist. - Add
frontend/static/languages/code_objective_c.jsonwordlist (withnoLazyMode: true).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/schemas/src/languages.ts | Extends language enum to include code_objective_c. |
| frontend/src/ts/constants/languages.ts | Adds code_objective_c to the code language group for UI grouping. |
| frontend/static/languages/code_objective_c.json | Introduces the Objective-C wordlist consumed by the language loader. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Objective-C language as a new language, which is interesting because there's swift but not objective-C. Went through and added languages
Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languageshappy to contribute something small to the best typing game in the world :D