Skip to content

refactor: optimize sound-controller (@fehmer)#7884

Open
fehmer wants to merge 14 commits intomasterfrom
feature/refactor-soundcontroller
Open

refactor: optimize sound-controller (@fehmer)#7884
fehmer wants to merge 14 commits intomasterfrom
feature/refactor-soundcontroller

Conversation

@fehmer
Copy link
Copy Markdown
Member

@fehmer fehmer commented Apr 28, 2026

  • extract and simplify config
  • add sounds to check-assets validation
  • only load the selected click sound bundle, not all

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Apr 28, 2026
@fehmer fehmer added force-ci Force CI to run on draft PRs assets Languages, themes, layouts, etc. labels Apr 28, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 29, 2026

@fehmer fehmer marked this pull request as ready for review April 29, 2026 10:28
@github-actions github-actions Bot added the waiting for review Pull requests that require a review before continuing label Apr 29, 2026
@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: Basic FTP has Path Traversal Vulnerability in its downloadToDir() method in npm basic-ftp

CVE: GHSA-5rq4-664w-9x2c Basic FTP has Path Traversal Vulnerability in its downloadToDir() method (CRITICAL)

Affected versions: < 5.2.0

Patched version: 5.2.0

From: pnpm-lock.yamlnpm/basic-ftp@5.0.5

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/basic-ftp@5.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. force-ci Force CI to run on draft PRs frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants