feat(items): add per-type column value helpers (email/phone/link/checkbox/dropdown)#43
Open
luarss wants to merge 2 commits into
Open
feat(items): add per-type column value helpers (email/phone/link/checkbox/dropdown)#43luarss wants to merge 2 commits into
luarss wants to merge 2 commits into
Conversation
…kbox/dropdown)
Fills in the missing `change_*_column_value` siblings to match the
existing pattern of `change_status_column_value` and
`change_date_column_value`. Each new helper wraps the correct JSON shape
expected by Monday's column_values API:
change_email_column_value -> {"email": ..., "text": ...}
change_phone_column_value -> {"phone": ..., "countryShortName": ...}
change_link_column_value -> {"url": ..., "text": ...}
change_checkbox_column_value -> {"checked": "true"} or {}
change_dropdown_column_value -> {"labels": [...]}
Before this change, callers either had to memorize the JSON shapes and
pass them to `change_custom_column_value` directly, or look them up in
Monday's API reference each time. The docstring on
`change_custom_column_value` is updated to point at the type-specific
helpers and now serves as the escape hatch for column types that don't
have one yet (country, location, people, tags).
Existing change_*_column_value helpers (simple/status/date) have no docstrings; match that for the new ones. Reverts the change_custom_column_value docstring to the original informal 'for X columns, use Y' list format, just extended with the new helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.