Add Container.validate() for cycle detection#176
Closed
Conversation
Track the resolution stack per-thread via threading.local shared across the container tree. When a provider is encountered that is already being resolved on the current thread, raise RuntimeError with the full cycle path (e.g. "CycleA -> CycleB -> CycleA") instead of hitting a RecursionError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Container.validate()method that walks the provider graph via DFS and detects circular dependencies, raisingRuntimeErrorwith the full cycle path (e.g. "CycleA -> CycleB -> CycleA")validate=Falseparameter toContainer.__init__for opt-in validation at creation timeget_dependencies()method toAbstractProviderandFactoryto expose dependency edges without accessing internals__iter__toProvidersRegistryfor clean graph traversalTest plan
validate=Trueflag triggers detection at container creation