feat: unify instrument skip feedback through warning subclasses#86
Merged
feat: unify instrument skip feedback through warning subclasses#86
Conversation
Both bootstrap skip paths (missing dependency, not ready) now emit warnings.warn with distinct UserWarning subclasses (InstrumentDependencyMissingWarning, InstrumentNotReadyWarning, sharing InstrumentSkippedWarning base) so users can filter, capture, or escalate each independently. Previously not-ready skips went to logger.info and were silently dropped before the logging instrument finished bootstrapping. Also drop stale service_debug=False notes from the docs (logging is now gated by logging_enabled, default True). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both bootstrap skip paths (missing dependency, not ready) now emit warnings.warn with distinct UserWarning subclasses (InstrumentDependencyMissingWarning, InstrumentNotReadyWarning, sharing InstrumentSkippedWarning base) so users can filter, capture, or escalate each independently. Previously not-ready skips went to logger.info and were silently dropped before the logging instrument finished bootstrapping.
Also drop stale service_debug=False notes from the docs (logging is now gated by logging_enabled, default True).