feat: add logging_enabled flag, decouple from service_debug#85
Merged
feat: add logging_enabled flag, decouple from service_debug#85
Conversation
LoggingInstrument.is_ready() previously returned False whenever service_debug=True — and BaseConfig.service_debug defaults to True. So out of the box, the structured-logging instrument silently skipped its own bootstrap, and users assumed the JSON logging pipeline was working when it wasn't. Add a dedicated logging_enabled: bool = True field on LoggingConfig and gate is_ready() on it instead. service_debug stays focused on framework debug mode (FastAPI/Litestar app.debug). Default behavior changes: projects with no overrides now get structured logging. Users who want the old skip-logging behavior set logging_enabled=False explicitly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoggingInstrument.is_ready() previously returned False whenever service_debug=True — and BaseConfig.service_debug defaults to True. So out of the box, the structured-logging instrument silently skipped its own bootstrap, and users assumed the JSON logging pipeline was working when it wasn't.
Add a dedicated logging_enabled: bool = True field on LoggingConfig and gate is_ready() on it instead. service_debug stays focused on framework debug mode (FastAPI/Litestar app.debug). Default behavior changes: projects with no overrides now get structured logging. Users who want the old skip-logging behavior set logging_enabled=False explicitly.