Ramsess/fix release pipeline#3593
Open
ramsessanchez wants to merge 19 commits intomainfrom
Open
Conversation
Contributor
Author
gavinbarron
reviewed
Apr 28, 2026
| customCommand: install -g autorest@3.7.2 | ||
|
|
||
| workingDir: $(Build.SourcesDirectory) | ||
| customCommand: install -g autorest@3.7.2 --registry https://microsoftgraph.pkgs.visualstudio.com/0985d294-5762-4bc2-a565-161ef349ca3e/_packaging/PowerShell_V2_Build/npm/registry/ |
Member
There was a problem hiding this comment.
shouldn't this just point at the authenticated .npmrc file and thus avoid having this same URL duplicated all over the place?
Contributor
Author
There was a problem hiding this comment.
this was required due to the -global install, since global install wouldn't use the local authentication file. Changed to a local install and this flag is no longer needed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release/generation tooling to work in network-isolated pipelines by eliminating PSGallery dependency for YAML parsing, preconfiguring private feeds, and pre-populating AutoRest extension caches to avoid registry lookups during generation.
Changes:
- Replaced
ConvertFrom-Yamlusage with a lightweight YAML key/value parser to remove thepowershell-yamlinstall step. - Updated pipeline/tooling to authenticate against a private npm feed, pre-install AutoRest extensions into
~/.autorest, and run Rush vianpx. - Adjusted module dependency management to rely on configured NuGet sources instead of forcing nuget.org.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/WriteToModuleReadMe.ps1 | Replaces ConvertFrom-Yaml with a simple YAML parser for the Versioning block. |
| tools/ReadModuleReadMe.ps1 | Same simple YAML parsing change for reading versioning fields. |
| tools/ManageGeneratedModule.ps1 | Removes explicit nuget.org source when adding packages. |
| tools/GenerateServiceModule.ps1 | Forces AutoRest to load @autorest/modelerfour from a local cache and captures verbose logs to a file. |
| tools/GenerateModules.ps1 | Removes PSGallery dependency, switches Rush invocation to npx, and adds diagnostics about cache/registry state. |
| tools/Configure-PrivateNpmFeed.ps1 | Adds generation of a repo-local NuGet.config pointing to the private feed. |
| .azure-pipelines/common-templates/install-tools.yml | Copies authenticated .npmrc to user profile, installs tools, pre-populates ~/.autorest extension cache, and runs Rush via npx. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+123
to
+127
| npx rush install | ||
| if ($LASTEXITCODE -ne 0) { throw "rush install failed with exit code $LASTEXITCODE" } | ||
| npx rush link | ||
| if ($LASTEXITCODE -ne 0) { throw "rush link failed with exit code $LASTEXITCODE" } | ||
| npx rush rebuild |
Comment on lines
+39
to
+41
| # Create NuGet.config to redirect dotnet restore to the private feed | ||
| $nugetFeed = $Registry -replace "/npm/registry/$", "/nuget/v3/index.json" | ||
| $nugetConfig = @" |
| } | ||
|
|
||
| $autorestLog = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), "autorest-$($ModuleFullName -replace '[^a-zA-Z0-9-]', '-').log") | ||
| npx autorest @modelerFourUseFlag --verbose --max-memory-size=$MaxMemorySize --module-version:$FullModuleVersion --module-name:$ModuleFullName --service-name:$Module --input-file:$OpenApiFile $AutoRestModuleConfig --max-cpu=2 --network-calls=2 2>&1 | Out-File -FilePath $autorestLog -Encoding utf8 |
Comment on lines
+51
to
+52
| npx rush install | ||
| npx rush build |
Comment on lines
+74
to
+75
| Write-Host "npm registry: $(npm config get registry 2>&1)" | ||
| Write-Host "npm_config_registry env: $env:npm_config_registry" |
Comment on lines
64
to
+76
| - task: Npm@1 | ||
| displayName: Install AutoRest | ||
| inputs: | ||
| command: custom | ||
| customCommand: install -g autorest@3.7.2 | ||
|
|
||
| workingDir: $(Build.SourcesDirectory) | ||
| customCommand: install autorest@3.7.2 | ||
|
|
||
| - task: Npm@1 | ||
| displayName: Install AutorestCore | ||
| inputs: | ||
| command: custom | ||
| customCommand: install -g @autorest/core@3.10.4 | ||
| workingDir: $(Build.SourcesDirectory) | ||
| customCommand: install @autorest/core@3.10.4 |
Member
There was a problem hiding this comment.
@ramsessanchez looks like there's a good reason not to use local installs over global installs, that said I think you can use the -c option to pass the .npmrc file that points at the private registry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure all npm calls are skipped during autorest generation release by pre-downloading dependencies from private registry so that the pipeline is compliant with network isolation policies in release job workflow.