fix(reviewManager): use pr.base.ref instead of pr.base.name in hasBranch call#8698
Merged
alexr00 merged 2 commits intomicrosoft:mainfrom Apr 24, 2026
Merged
Conversation
…nch call pr.base.ref is the branch name (e.g., "main") while pr.base.name is the repository name. hasBranch() expects a branch name, so passing pr.base.name would always query refs/heads/<repo-name> which never matches an actual branch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alexr00
approved these changes
Apr 23, 2026
alexdima
approved these changes
Apr 23, 2026
Member
|
/AzurePipelines run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
alexr00
approved these changes
Apr 23, 2026
Member
|
/AzurePipelines run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasBranch()call to usepr.base.ref(branch name) instead ofpr.base.name(repository name)Why
In
resolvePullRequest(), the checkhasBranch(pr.base.name)was passing the repository name instead of the branch name:pr.base.ref= branch name (e.g.,"main")pr.base.name= repository name (e.g.,"vscode-pull-request-github")This caused
hasBranch()to queryrefs/heads/<repo-name>which never matches an actual branch, making the validation always fail.Validation
pr.base.refis the correct property for branch name lookupRelated
Fixes #8668