Skip to content

Add date range filtering and fix test infrastructure #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxgolov wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add date range filtering and fix test infrastructure #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5dfb7b
Add date range filtering, fix test infrastructure
maxgolov Feb 12, 2026
714ab89
fix: resolve CodeQL type confusion through parameter tampering
maxgolov Feb 13, 2026
962f3a4
fix(review): address PR #25 Copilot comments and bump deps
maxgolov May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,344 changes: 1,691 additions & 1,653 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

53 changes: 27 additions & 26 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,39 +31,40 @@
"author": "Microsoft",
"license": "MIT",
"dependencies": {
"@modelcontextprotocol/sdk": "^1.26.0",
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/api-logs": "^0.211.0",
"@opentelemetry/auto-instrumentations-node": "^0.69.0",
"@opentelemetry/exporter-logs-otlp-http": "^0.211.0",
"@opentelemetry/exporter-metrics-otlp-http": "^0.211.0",
"@opentelemetry/exporter-trace-otlp-http": "^0.211.0",
"@opentelemetry/instrumentation": "^0.211.0",
"@opentelemetry/instrumentation-express": "^0.59.0",
"@opentelemetry/instrumentation-http": "^0.211.0",
"@opentelemetry/instrumentation-winston": "^0.55.0",
"@opentelemetry/resources": "^2.2.0",
"@opentelemetry/sdk-logs": "^0.211.0",
"@opentelemetry/sdk-metrics": "^2.2.0",
"@opentelemetry/sdk-node": "^0.211.0",
"@opentelemetry/sdk-trace-base": "^2.2.0",
"@opentelemetry/sdk-trace-node": "^2.2.0",
"@opentelemetry/semantic-conventions": "^1.39.0",
"@modelcontextprotocol/sdk": "^1.29.0",
"@opentelemetry/api": "^1.9.1",
"@opentelemetry/api-logs": "^0.216.0",
"@opentelemetry/auto-instrumentations-node": "^0.74.0",
"@opentelemetry/exporter-logs-otlp-http": "^0.216.0",
"@opentelemetry/exporter-metrics-otlp-http": "^0.216.0",
"@opentelemetry/exporter-trace-otlp-http": "^0.216.0",
"@opentelemetry/instrumentation": "^0.216.0",
"@opentelemetry/instrumentation-express": "^0.64.0",
"@opentelemetry/instrumentation-http": "^0.216.0",
"@opentelemetry/instrumentation-winston": "^0.60.0",
"@opentelemetry/resources": "^2.7.1",
"@opentelemetry/sdk-logs": "^0.216.0",
"@opentelemetry/sdk-metrics": "^2.7.1",
"@opentelemetry/sdk-node": "^0.216.0",
"@opentelemetry/sdk-trace-base": "^2.7.1",
"@opentelemetry/sdk-trace-node": "^2.7.1",
"@opentelemetry/semantic-conventions": "^1.40.0",
"cors": "^2.8.6",
"express": "^5.0.1",
"winston": "^3.18.3",
"zod": "^4.3.6"
"zod": "^4.4.2"
},
"devDependencies": {
"@ai-sdk/azure": "^3.0.27",
"@azure/identity": "^4.13.0",
"@ai-sdk/azure": "^3.0.59",
"@azure/identity": "^4.13.1",
"@types/cors": "^2.8.17",
"@types/express": "^5.0.0",
"@types/node": "^25.2.3",
"ai": "^6.0.79",
"dotenv": "^17.2.4",
"typescript": "^5.7.2",
"vitest": "^4.0.18"
"@types/node": "^25.6.0",
"@vitest/coverage-v8": "^4.1.5",
"ai": "^6.0.174",
"dotenv": "^17.4.2",
"typescript": "^5.9.3",
"vitest": "^4.1.5"
},
"engines": {
"node": ">=18.0.0"
Expand Down
64 changes: 62 additions & 2 deletions src/datasources/local-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,66 @@ export class LocalRepositoryDataSource implements IAdvisoryDataSource {
};
}

/**
* Parse date filter string and return start/end dates.
* Supports: "2026-01-27" (single day) or "2026-01-01..2026-01-31" (range).
*
* Throws an Error with a descriptive message when the input is malformed:
* - more than two parts in a range
* - missing start or end in a range
* - invalid calendar date (e.g. "2026-13-45")
* - reversed range (start > end)
*/
private parseDateFilter(dateStr: string): { start: string; end: string } {
// Defense-in-depth: ensure dateStr is a string (HTTP query params can be arrays)
const str = Array.isArray(dateStr) ? String(dateStr[0]) : String(dateStr);

if (str.includes('..')) {
const parts = str.split('..');
if (parts.length !== 2 || !parts[0] || !parts[1]) {
throw new Error(
`Invalid date range "${str}". Expected "YYYY-MM-DD..YYYY-MM-DD".`
);
}
const [start, end] = parts;
const startDate = new Date(start + 'T00:00:00Z');
const endDate = new Date(end + 'T00:00:00Z');
if (isNaN(startDate.getTime()) || isNaN(endDate.getTime())) {
throw new Error(
`Invalid date in range "${str}". Each side must be YYYY-MM-DD.`
);
}
if (startDate.getTime() > endDate.getTime()) {
throw new Error(
`Invalid date range "${str}": start date must be less than or equal to end date.`
);
}
// End date: include full day by using next day midnight (end is exclusive)
endDate.setUTCDate(endDate.getUTCDate() + 1);
return { start: startDate.toISOString(), end: endDate.toISOString() };
}

// Single date: filter for that specific day
const startDate = new Date(str + 'T00:00:00Z');
const endDate = new Date(str + 'T00:00:00Z');
if (isNaN(startDate.getTime()) || isNaN(endDate.getTime())) {
throw new Error(`Invalid date "${str}". Expected YYYY-MM-DD.`);
}
endDate.setUTCDate(endDate.getUTCDate() + 1);
return { start: startDate.toISOString(), end: endDate.toISOString() };
}

/**
* Filter advisories by date range
*/
private filterByDateRange(advisories: Advisory[], field: 'published_at' | 'updated_at', dateStr: string): Advisory[] {
const { start, end } = this.parseDateFilter(dateStr);
return advisories.filter(a => {
const date = a[field];
return date >= start && date < end;
});
}
Comment on lines +304 to +362
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new parseDateFilter and filterByDateRange methods lack unit test coverage. While there are E2E tests that exercise these methods indirectly, there are no unit tests that validate edge cases such as invalid dates, reversed date ranges, malformed input, or boundary conditions.

Consider adding unit tests for the LocalRepositoryDataSource class to cover these critical date parsing scenarios, following the pattern established in test/unit/refresh-database.test.ts.

Copilot uses AI. Check for mistakes.

/**
* List advisories with optional filtering
*/
Expand Down Expand Up @@ -349,11 +409,11 @@ export class LocalRepositoryDataSource implements IAdvisoryDataSource {
}

if (options.published) {
results = results.filter(a => a.published_at >= options.published!);
results = this.filterByDateRange(results, 'published_at', options.published);
}

if (options.updated) {
results = results.filter(a => a.updated_at >= options.updated!);
results = this.filterByDateRange(results, 'updated_at', options.updated);
}

// Sort results
Expand Down
Loading
Loading