[Shopify] Refresh cached plan before order sync

[onbuyuka]

Summary

Bug 635878: When a merchant downgrades their Shopify plan from Plus / Advanced to a standard plan, the connector keeps requesting the staffMember { id } field in the order GraphQL query. The lower plan does not grant read_users scope, so Shopify returns ACCESS_DENIED and order sync is fully broken until the user manually toggles the Enabled field off and on again on the Shop Card.

Shop."Advanced Shopify Plan" (field 207) is the cached flag that gates the staff member field. It was only refreshed when the user toggled Enabled or when a scope change was detected on Shop Card open — never before an order sync.

Fix

Auto-refresh the cached plan via the existing Shop.GetShopSettings() helper (one cheap GraphQL query for shop { plan { ... } weightUnit }) before both order-import entry points:

1. Bulk sync — Report 30104 Shpfy Sync Orders from Shopify (also the scheduled auto-sync path). One refresh call per shop per batch run.
2. Single-order reimport — ShpfyImportOrder.ReimportExistingOrderConfirmIfConflicting (manual reimport action on the Order Header page).

The refresh is deliberately not placed in ShpfyImportOrder.SetShop() because that runs per order; for a 100-order batch it would mean 100 extra GraphQL round-trips.

Tests

Two regression tests added to the existing ShpfyOrdersAPITest.Codeunit.al (139608):

• TestGetShopSettingsClearsStaleAdvancedShopifyPlanFlag — sets stale "Advanced Shopify Plan" = true, calls GetShopSettings, asserts the flag becomes false.
• TestSyncOrdersFromShopifyReportRefreshesAdvancedShopifyPlanFlag — sets stale flag, runs Report 30104, asserts the persisted Shop record has the flag refreshed to false.

Existing OrdersAPIHttpHandler extended with a one-shot PlanRefreshExpected flag returning a downgraded-plan JSON for the first request, then falling through to the prior empty-data behavior.

Both tests verified locally.

Fixes AB#635878

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Unhandled API failure can abort entire report

Shop.GetShopSettings() makes a live HTTP call to the Shopify API inside OnAfterGetRecord. If the API is unavailable, rate-limited, or returns an error, the exception propagates unhandled and aborts the entire report run, potentially leaving no orders imported.

Recommendation:

• Wrap the call in a if not TryGetShopSettings() then guard or use Codeunit.Run with error handling so that a transient API failure degrades gracefully rather than aborting the report.

if not TryGetShopSettings(Shop) then
    // log or skip; continue with existing cached settings
else
    Shop.Modify(false);

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Modify() runs OnModify trigger unintentionally

ShopToRefresh.Modify() without false fires the OnModify table trigger on the Shpfy Shop record. The only intent is to persist the refreshed plan settings returned by GetShopSettings(); triggering the full modify business logic is an unintended side effect.

Recommendation:

• Pass false to suppress the trigger: ShopToRefresh.Modify(false);

Suggested change

	ShopToRefresh.Modify();
	if ShopToRefresh.Get(OrderHeader."Shop Code") then begin
	ShopToRefresh.GetShopSettings();
	ShopToRefresh.Modify(false);
	end;

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Modify() runs OnModify trigger unintentionally

Shop.Modify() without a false argument defaults to RunTrigger := true, which fires the OnModify table trigger on every shop record the report iterates. The intent here is only to persist the settings fetched by GetShopSettings(); triggering business logic in OnModify may cause unintended side effects or duplicate work.

Recommendation:

• Pass false to suppress the trigger: Shop.Modify(false);

Suggested change

	Shop.Modify();
	Shop.GetShopSettings();
	Shop.Modify(false);

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}