Skip to content

Make agent tool confirmations optional#379

Merged
h4yfans merged 2 commits into
mainfrom
feat/agent-tool-confirmation-settings
May 13, 2026
Merged

Make agent tool confirmations optional#379
h4yfans merged 2 commits into
mainfrom
feat/agent-tool-confirmation-settings

Conversation

@h4yfans
Copy link
Copy Markdown
Collaborator

@h4yfans h4yfans commented May 13, 2026

Summary

  • Add an Agent Chat tool confirmation preference with Always accept as the default and Ask first as the manual approval mode.
  • Keep tool-call details visible in chat as collapsed tool rows across running, completed, error, denied, and approval states.
  • Wire the preference through contracts, IPC, preload, settings UI, runtime gating, sync payloads, and docs.

Validation

  • pnpm --dir apps/desktop exec vitest run --config config/vitest.config.ts src/main/agent/runtime/__tests__/permission-gate.test.ts src/main/agent/runtime/__tests__/runtime-approval.test.ts src/main/agent/settings.test.ts src/main/ipc/agent-handlers.test.ts src/preload/api/preload-api.test.ts src/renderer/src/agent-chat/__tests__/agent-context.test.tsx src/renderer/src/agent-chat/__tests__/message-stream.test.tsx src/renderer/src/pages/settings/settings-sections.test.tsx ../../packages/contracts/src/ipc-agent.test.ts
  • pnpm typecheck:desktop
  • pnpm --filter @memry/contracts typecheck
  • pnpm ipc:check
  • pnpm i18n:check
  • pnpm docs:impact --base f2e73d93a899043aa859b4c90a07c14bab19dc99 --strict
  • pnpm docs:build
  • pnpm lint:desktop

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
memry-docs Ready Ready Preview, Comment May 13, 2026 11:40am
memrynote-landing Ready Ready Preview, Comment May 13, 2026 11:40am

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@h4yfans h4yfans marked this pull request as ready for review May 13, 2026 04:59
@h4yfans h4yfans merged commit 7a8ca27 into main May 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant