feat(integration): compute services from matrix#354
Merged
rhoerr merged 1 commit intomage-os:mainfrom May 7, 2026
Merged
Conversation
6 tasks
rhoerr
approved these changes
May 7, 2026
Contributor
rhoerr
left a comment
There was a problem hiding this comment.
generate-mirror-repo-js should be unaffected. Action references are all @main. Tonight's upstream-nightly run will confirm.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the
integrationworkflow uses hard-coded services which only happenstance work across the matrix of service versions that we test against.For example, if between opensearch 1 / 2 / 3, they decided to change the environment variables around (they did):
Then the integration tests would break for only some versions.
Touches: #338
What is the new behavior?
Instead, we derive the services matrix in
supported-versionas of #353 and now we use it here.Does this PR introduce a breaking change?
I don't expect this to be breaking. However, if people are using consistent versions.
However, scenarios like:
supported-version@1.0.0withintegration@mainwould break.The
generate-mirror-repo-jsdepends on this action it should be validated against this PR before merge. I reviewed other dependents:and the UI is inaccurate the other repos don't use this action.