Skip to content

feat(integration): compute services from matrix#354

Merged
rhoerr merged 1 commit intomage-os:mainfrom
damienwebdev:computed-services-integration
May 7, 2026
Merged

feat(integration): compute services from matrix#354
rhoerr merged 1 commit intomage-os:mainfrom
damienwebdev:computed-services-integration

Conversation

@damienwebdev
Copy link
Copy Markdown
Member

@damienwebdev damienwebdev commented May 6, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, the integration workflow uses hard-coded services which only happenstance work across the matrix of service versions that we test against.

For example, if between opensearch 1 / 2 / 3, they decided to change the environment variables around (they did):

DISABLE_INSTALL_DEMO_CONFIG: true
DISABLE_SECURITY_PLUGIN: true

Then the integration tests would break for only some versions.

Touches: #338

What is the new behavior?

Instead, we derive the services matrix in supported-version as of #353 and now we use it here.

Does this PR introduce a breaking change?

  • Yes
  • No

I don't expect this to be breaking. However, if people are using consistent versions.

However, scenarios like: supported-version@1.0.0 with integration@main would break.

The generate-mirror-repo-js depends on this action it should be validated against this PR before merge. I reviewed other dependents:

image

and the UI is inaccurate the other repos don't use this action.

Copy link
Copy Markdown
Contributor

@rhoerr rhoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate-mirror-repo-js should be unaffected. Action references are all @main. Tonight's upstream-nightly run will confirm.

@rhoerr rhoerr merged commit 7c8ffc3 into mage-os:main May 7, 2026
4 of 5 checks passed
@rhoerr
Copy link
Copy Markdown
Contributor

rhoerr commented May 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants