feat(setup-install): create new action#349
Conversation
|
This is blocked by #351 |
|
351 merged; any changes or rebase needed here? |
23c9d1e to
060c0e3
Compare
|
This wound up blocked by #353 -- this will need a rebase once merged. |
060c0e3 to
fc7fc8d
Compare
Code reviewFound 2 issues:
github-actions/setup-install/README.md Lines 37 to 69 in fc7fc8d
github-actions/setup-install/src/build-command.ts Lines 7 to 15 in fc7fc8d 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
|
I did a visual inspection then ran the above. The services feedback might not be meaningful. Possibly best to have them fully isolated in this way. The readme reference issue looks valid. I saw you have the same or similar at https://github.com/graycoreio/github-actions-magento2/tree/main/setup-install . All good there? |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, users have to awkward run
setup:installthemselves based upon matrix configuration. This sucks.Fixes: #350
What is the new behavior?
Users can user
setup-installwith theservicesmatrix configuration and Magento will install based upon that service config.Does this PR introduce a breaking change?
Other information