fix(firmware): include factory MAC in WS avatar URL query#29
Open
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Open
fix(firmware): include factory MAC in WS avatar URL query#29Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Conversation
The server's web_socket.Handler rejects connections without both
'mac' and 'deviceType' query parameters (server/internal/web_socket/
web_socket.go:89-92):
mac := r.Get(\"mac\").String()
deviceType := r.Get(\"deviceType\").String()
if mac == \"\" || deviceType == \"\" {
r.Response.Write(\"The mac and deviceType parameters are empty.\")
return
}
Before this change, hal_ws_avatar built the URL with only
?deviceType=StackChan, so every WebSocket handshake was silently
rejected. Observable on-device as endless 'WS-Avatar: Failed to
connect' retries; observable server-side as a TCP connection that
upgrades, receives the upgrade request, and is abandoned without a
WS upgrade.
Read the factory MAC at init() and inject it in the URL, matching
the format the iOS app already uses:
?mac=441BF6E48694&deviceType=StackChan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server's web_socket.Handler rejects connections without both
'mac' and 'deviceType' query parameters (server/internal/web_socket/
web_socket.go:89-92):
Before this change, hal_ws_avatar built the URL with only
?deviceType=StackChan, so every WebSocket handshake was silently
rejected. Observable on-device as endless 'WS-Avatar: Failed to
connect' retries; observable server-side as a TCP connection that
upgrades, receives the upgrade request, and is abandoned without a
WS upgrade.
Read the factory MAC at init() and inject it in the URL, matching
the format the iOS app already uses:
?mac=441BF6E48694&deviceType=StackChan