fix(ios): correct swapped deviceOnline/deviceOffline bool assignments#28
Open
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Open
fix(ios): correct swapped deviceOnline/deviceOffline bool assignments#28Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Conversation
In webSocketMessageMonitoring, the WS message handler was doing the opposite of what the names imply: - MsgType.deviceOnline set deviceIsOnline = false - MsgType.deviceOffline set deviceIsOnline = true Obvious typo in the upstream code. Once the StackChan successfully opened its avatar WS to the server, the server pushed a deviceOnline notification to the App and the App mislabelled the status as offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In webSocketMessageMonitoring, the WS message handler was doing the
opposite of what the names imply:
Obvious typo in the upstream code. Once the StackChan successfully
opened its avatar WS to the server, the server pushed a deviceOnline
notification to the App and the App mislabelled the status as offline.