feat(firmware): add CONFIG_STACKCHAN_SERVER_URL Kconfig option#21
Open
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Open
feat(firmware): add CONFIG_STACKCHAN_SERVER_URL Kconfig option#21Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Flo5k5 wants to merge 1 commit intom5stack:mainfrom
Conversation
Expose the StackChan backend base URL as a Kconfig string so it can be overridden via menuconfig or sdkconfig.defaults.local without patching source files. This follows the same pattern as the existing CONFIG_OTA_URL option used by the Xiaozhi Assistant pipeline. The weak-linked secret_logic::get_server_url() now returns CONFIG_STACKCHAN_SERVER_URL when defined, and keeps the previous localhost:3000 stub as a fallback for builds that omit the config. The default value equals the current production server, so firmware builds without an explicit override keep talking to the same backend they do today (no regression). Intended usage with this option relies on hal_account.cpp and hal_app_center.cpp going through secret_logic::get_server_url() as well (see the companion refactor). Until that lands, only hal_ws_avatar.cpp honours the override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the StackChan backend base URL as a Kconfig string so it can be
overridden via menuconfig or sdkconfig.defaults.local without patching
source files. This follows the same pattern as the existing
CONFIG_OTA_URL option used by the Xiaozhi Assistant pipeline.
The weak-linked secret_logic::get_server_url() now returns
CONFIG_STACKCHAN_SERVER_URL when defined, and keeps the previous
localhost:3000 stub as a fallback for builds that omit the config.
The default value equals the current production server, so firmware
builds without an explicit override keep talking to the same backend
they do today (no regression).
Intended usage with this option relies on hal_account.cpp and
hal_app_center.cpp going through secret_logic::get_server_url() as well
(see the companion refactor). Until that lands, only hal_ws_avatar.cpp
honours the override.