DM-54625: Update preconvolution with recent diffim improvements#453
Open
DM-54625: Update preconvolution with recent diffim improvements#453
Conversation
isullivan
force-pushed
the
tickets/DM-54625
branch
from
1516e2a to
a51832a
Compare
isullivan
changed the title
isullivan
force-pushed
the
tickets/DM-54625
branch
from
3a48aa0 to
8b113d3
Compare
isullivan
force-pushed
the
tickets/DM-54625
branch
2 times, most recently
from
d1e3003 to
c6eea82
Compare
Also make sure to use a consistent PSF size for preconvolution and decorrelation.
isullivan
force-pushed
the
tickets/DM-54625
branch
from
16c5660 to
8a2e2ab
Compare
Otherwise the results are unstable when the science image has a psfSize of 2.0 in the unit tests and the template has a psfSize of 2.3 to 2.4. This change makes the basis a smooth transition instead of a sudden jump.
This does not suffer from the same bug as setting the image plane to 0 for masked pixels, since the peak is removed after detection.
isullivan
force-pushed
the
tickets/DM-54625
branch
from
8a2e2ab to
cd5766b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.