feat(ci): enforce conventional commits#186
Merged
machshev merged 1 commit intolowRISC:masterfrom Apr 29, 2026
Merged
Conversation
Conventional commits are required for the automated release process to work out what type of release to make. Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
machshev
force-pushed
the
enforce-conventional-commits
branch
from
4c738b9 to
0947063
Compare
martin-velay
approved these changes
Apr 29, 2026
Contributor
martin-velay
left a comment
martin-velay
left a comment
There was a problem hiding this comment.
That's a good idea to integrate this check into the CI for each commit. Thanks James
Contributor
|
As well as a CI check, we should add some docs to the contribution guidelines / a pre-populated PR message or some other sort of automated popup that reminds users they need to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to ensure that all commit messages are conventional commits as the auto release mechanism relies on this to work out what type of release to make. If it's a
fix:then it will just do a patch release,feat:is a minor release, and breaking change is a major release.Recently we had a commit go through that didn't have this format and it meant there was no release triggered.