Skip to content

Cleanup Audio Dispatch#267

Closed
MaxHeimbrock wants to merge 1 commit intomainfrom
max/cleanup-audio-dispatch
Closed

Cleanup Audio Dispatch#267
MaxHeimbrock wants to merge 1 commit intomainfrom
max/cleanup-audio-dispatch

Conversation

@MaxHeimbrock
Copy link
Copy Markdown
Contributor

@MaxHeimbrock MaxHeimbrock commented Apr 29, 2026 •
edited
Loading

Background

Audio dispatch is handled separately and happens above the main thread dispatch and switch case:

if (response.MessageCase == FfiEvent.MessageOneofCase.AudioStreamEvent)
{
  Instance.AudioStreamEventReceived?.Invoke(response.AudioStreamEvent!);
  return;
}

Changes

  • Remove case FfiEvent.MessageOneofCase.AudioStreamEvent from switch case

@MaxHeimbrock MaxHeimbrock force-pushed the max/cleanup-audio-dispatch branch from 07a5382 to 358ee26 Compare April 29, 2026 13:52
MaxHeimbrock
MaxHeimbrock commented Apr 29, 2026
View reviewed changes
Comment thread Runtime/Scripts/Internal/FFIClient.cs

// Audio stream events are handled directly on the FFI callback thread
// to bypass the main thread, since the audio thread consumes the data
if (response.MessageCase == FfiEvent.MessageOneofCase.AudioStreamEvent)
Copy link
Copy Markdown
Contributor Author

@MaxHeimbrock MaxHeimbrock Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we already handle the audio case.

@MaxHeimbrock
Copy link
Copy Markdown
Contributor Author

MaxHeimbrock commented Apr 30, 2026

Done in:
#269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MaxHeimbrock