Open
Conversation
When called, waits for all in flight packets to be sent before resolving. Use this to: 1. Send frames exactly in order: ```ts await track.tryPush(/* ... *\/); await track.flush(); await track.tryPush(/* ... *\/); await track.flush(); // ... etc ... ``` 2. Wait for frames to all be delivered before unpublishing a local data track: ```ts await track.tryPush(/* ... *\/); await track.tryPush(/* ... *\/); await track.tryPush(/* ... *\/); // ... etc ... await track.flush(); await track.unpublish(); ```
🦋 Changeset detectedLatest commit: 0914a18 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
lukasIO
reviewed
Apr 29, 2026
| protected log: StructuredLogger = log; | ||
|
|
||
| /** Resolves once the data track has sent all pending packets the rtc data channel buffer. */ | ||
| protected flushedFuture = new Future<void, never>(); |
Contributor
There was a problem hiding this comment.
what should happen to this future if the room disconnects while flushing?
| this.engine.sendLossyBytes(bytes, DataChannelKind.DATA_TRACK_LOSSY, 'wait'); | ||
| .on('packetAvailable', ({ handle, bytes }) => { | ||
| this.engine | ||
| .sendLossyBytes(bytes, DataChannelKind.DATA_TRACK_LOSSY, 'wait') |
Contributor
There was a problem hiding this comment.
if sendLossyBytes rejects should we still call the handlePacketSendComplete ? Otherwise the counter might get out of sync as there are no retries?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When called, waits for all in flight packets to be sent before resolving. Use this to: