Skip to content

move the LLM instance directly to Assistant to make it cleaner to share with tests#71

Open
bcherry wants to merge 5 commits intomainfrom
bcherry/cleaner-model-sharing
Open

move the LLM instance directly to Assistant to make it cleaner to share with tests#71
bcherry wants to merge 5 commits intomainfrom
bcherry/cleaner-model-sharing

Conversation

@bcherry
Copy link
Copy Markdown
Contributor

@bcherry bcherry commented Apr 30, 2026

this gets rid of the awkward AGENT_MODEL constant by just making the LLM an inherent property of the Assistant, which seems more intuitive

I also switched the test judge model to base 5.2 instead of the chat version to make it clearer that you can (and should) use a different model for evals than for core chat.

I'd like to move STT and TTS as well, but I found a bug we need to fix first

also see livekit-examples/agent-starter-node#43

@bcherry bcherry requested review from Topherhindman and u9g April 30, 2026 04:32
@u9g
Copy link
Copy Markdown
Contributor

u9g commented Apr 30, 2026

I also switched the test judge model to base 5.2 instead of the chat version to make it clearer that you can (and should) use a different model for evals than for core chat.

You did this by changing to 5.2 rather than 4.1-mini, I'm confused what you mean here, since the judge model was already discriminated from the agent model, and if anything you don't want a heavy judge model that will slow down every single test since IIRC we don't run tests in parallel by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants