Rework refresh loop, clean up APT code in mintUpdate.py#1058
Draft
mtwebster wants to merge 8 commits intolinuxmint:masterfrom
Draft
Rework refresh loop, clean up APT code in mintUpdate.py#1058mtwebster wants to merge 8 commits intolinuxmint:masterfrom
mtwebster wants to merge 8 commits intolinuxmint:masterfrom
Conversation
- Get rid of the refresh-last-run setting, only track it in-process. It was always ignored at startup, so the initial refresh would run regardless. It's mainly useful to adjust intervals when the user has pressed refresh manually. - Run the auto-refresh timer on the main loop with a re-usable GSource timer. - Remove the auto-refresh toggle handler, just rely on the settings- change handler. - Collect the thread handles returned from the _async decorator during refresh() to guard refresh_updates() - Move APT refresh/fetch_update work into APTCheck, use that class the same way we use our flatpak and cinnamon updaters.
so the refresh loop doesn't break.
- Clicking the checkbox amongst a selection will toggle all items. - Right-clicking within the selection will offer to ignore all selected updates. - The Packages notebook tab will show all packages included in the selection and their total size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was always ignored at startup, so the initial refresh would
run regardless. It's mainly useful to adjust intervals when the
user has pressed refresh manually.
GSource timer.
change handler.
during refresh() to guard refresh_updates()
the same way we use our flatpak and cinnamon updaters.