J1939: VP1/VP2 PG fixes#626
Open
SamantazFox wants to merge 4 commits intolinux-can:masterfrom
Open
Conversation
Since J1939DA:SEP2015, the repetition rate of VP1 has been changed to 1s.
Lat/longitude parameters have a range of -210 to +211.1081215
Add 3 missing unused bytes (for a message len of 8) to the j1939 VP2 struct, as well as range information for the existing parameters.
Contributor
|
Hi @SamantazFox , thank you for your work! The message data is build in Are you able to validate this services against any existing devices? Not required, just curious :) |
Author
|
@olerem you're welcome :)
I added the relevant logic in there.
Unfortunately no, I don't have such device handy. My work usually consists of working on vehicles that we don't own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to the commit messages for more details!
Note that I added the missing unused bytes to VP2, which as per the J1939 must always be
0xFF, but I'm not sure where to add that in the code (I don't see where the actual message data is built).Edit: for reference, here are the VP1 and VP2 layouts
