feat: add Bing and Google web search providers for AI discovery#114
Merged
feat: add Bing and Google web search providers for AI discovery#114
Conversation
Wire real search APIs into the AI agent's searchWeb/searchSites tools, which previously always returned empty results via DummySearchProvider. - BingSearchProvider: Bing Web Search API v7 with site: operators - GoogleSearchProvider: Google Custom Search JSON API with siteSearch - Auto-resolve from SearchConfig.provider in AiModule - CLI/Desktop/Android read BING_SEARCH_API_KEY or GOOGLE_SEARCH_API_KEY + GOOGLE_SEARCH_CX env vars to select the provider automatically - MockEngine integration tests for JSON parsing and error handling
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
# Conflicts: # app/desktop/src/main/kotlin/com/linroid/ketch/app/desktop/main.kt
- Extract resolveSearchConfigFromEnv() into ai:discover; drop 3 copies in CLI, Desktop, and Android - Add HttpTimeout to search HttpClient (matches fetcher) - Fall back to DummySearchProvider when provider is configured but credentials are blank; log a warning - Log caught exceptions in Bing/Google providers via KetchLogger - Rename default SearchConfig.provider from "llm" to "none" to match actual behavior - Remove unused BingWebPage.dateLastCrawled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BingSearchProvider(Bing Web Search API v7) andGoogleSearchProvider(Google Custom Search JSON API) as real implementations ofSearchProviderSearchConfig.providerinAiModule.create()— no manual wiring neededBING_SEARCH_API_KEYorGOOGLE_SEARCH_API_KEY+GOOGLE_SEARCH_CX) to auto-select the providerDummySearchProviderremains the fallback when no search API is configuredTest plan
buildQuery,buildMultiSiteQuery) with 0, 1, N sites./gradlew :ai:discover:testpassesBING_SEARCH_API_KEY=<key> OPENAI_API_KEY=<key> ./gradlew :cli:run --args="ai-discover 'ubuntu 24.04 iso'"GOOGLE_SEARCH_API_KEY=<key> GOOGLE_SEARCH_CX=<cx> OPENAI_API_KEY=<key> ./gradlew :cli:run --args="ai-discover 'ffmpeg download'"