Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-openapi studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-typescript studio · code · diff
✅ grid-python studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis PR updates Confidence Score: 4/5Safe to merge; changes are consistent documentation updates across all relevant schemas and generated bundles. All changes are in sync across source and generated files, and no logic or code is modified. One P2 suggestion about clarifying testnet/sandbox behavior with the new simplified naming scheme. No files require special attention; all changes are straightforward and consistent.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/crypto/EstimateCryptoWithdrawalFeeRequest.yaml | Updates cryptoNetwork description and example from SOLANA_MAINNET format to simplified SOLANA format; consistent with rest of PR. |
| openapi/components/schemas/external_accounts/ExternalAccount.yaml | Updates cryptoNetwork description and example to simplified network names; testnet variants removed without explanation of testnet behavior. |
| openapi/components/schemas/external_accounts/ExternalAccountCreateRequest.yaml | Updates cryptoNetwork description and example from SOLANA_MAINNET to SOLANA; consistent with other schema changes. |
| openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml | Updates cryptoNetwork description and example to simplified names; adds POLYGON and BITCOIN while removing all _MAINNET/_TESTNET variants. |
| openapi/paths/crypto/crypto_estimate-withdrawal-fee.yaml | Updates request body example value for cryptoNetwork from SOLANA_MAINNET to SOLANA. |
| openapi.yaml | Generated bundle (via make build) — reflects all source file changes consistently; should not be manually edited per CLAUDE.md. |
| mintlify/openapi.yaml | Generated Mintlify bundle — reflects all source file changes consistently. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
subgraph old ["Old cryptoNetwork Values"]
O1["SOLANA_MAINNET / SOLANA_DEVNET"]
O2["ETHEREUM_MAINNET / ETHEREUM_TESTNET"]
O3["BASE_MAINNET / BASE_TESTNET"]
O4["SPARK_MAINNET / SPARK_TESTNET"]
O5["LIGHTNING_MAINNET / LIGHTNING_REGTEST"]
end
subgraph new ["New cryptoNetwork Values"]
N1["SOLANA"]
N2["ETHEREUM"]
N3["BASE"]
N4["POLYGON"]
N5["SPARK"]
N6["LIGHTNING"]
N7["BITCOIN"]
end
O1 --> N1
O2 --> N2
O3 --> N3
O4 --> N5
O5 --> N6
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
openapi/components/schemas/external_accounts/ExternalAccount.yaml:47-50
**Testnet/devnet values no longer documented**
The updated descriptions drop all environment-specific variants (`SOLANA_DEVNET`, `ETHEREUM_TESTNET`, etc.) without explaining how sandbox/testnet traffic should be handled with the new naming scheme. If the API still supports a test environment (sandbox API keys, devnet routing, etc.), developers will have no guidance on what `cryptoNetwork` value to pass in that context. Consider adding a note clarifying whether the network value is environment-agnostic (i.e., `SOLANA` is used for both mainnet and devnet, with routing determined by the API key environment) or if testnet-specific values will be introduced. The same gap applies to `ExternalAccountCreateRequest.yaml`, `RealtimeFundingQuoteSource.yaml`, and `EstimateCryptoWithdrawalFeeRequest.yaml`.
Reviews (1): Last reviewed commit: "Update cryptoNetwork values" | Re-trigger Greptile
| is a cryptocurrency wallet. Example values: SOLANA, ETHEREUM, BASE, POLYGON, | ||
| SPARK, LIGHTNING, BITCOIN. | ||
| example: SOLANA | ||
| accountInfo: |
There was a problem hiding this comment.
Testnet/devnet values no longer documented
The updated descriptions drop all environment-specific variants (SOLANA_DEVNET, ETHEREUM_TESTNET, etc.) without explaining how sandbox/testnet traffic should be handled with the new naming scheme. If the API still supports a test environment (sandbox API keys, devnet routing, etc.), developers will have no guidance on what cryptoNetwork value to pass in that context. Consider adding a note clarifying whether the network value is environment-agnostic (i.e., SOLANA is used for both mainnet and devnet, with routing determined by the API key environment) or if testnet-specific values will be introduced. The same gap applies to ExternalAccountCreateRequest.yaml, RealtimeFundingQuoteSource.yaml, and EstimateCryptoWithdrawalFeeRequest.yaml.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccount.yaml
Line: 47-50
Comment:
**Testnet/devnet values no longer documented**
The updated descriptions drop all environment-specific variants (`SOLANA_DEVNET`, `ETHEREUM_TESTNET`, etc.) without explaining how sandbox/testnet traffic should be handled with the new naming scheme. If the API still supports a test environment (sandbox API keys, devnet routing, etc.), developers will have no guidance on what `cryptoNetwork` value to pass in that context. Consider adding a note clarifying whether the network value is environment-agnostic (i.e., `SOLANA` is used for both mainnet and devnet, with routing determined by the API key environment) or if testnet-specific values will be introduced. The same gap applies to `ExternalAccountCreateRequest.yaml`, `RealtimeFundingQuoteSource.yaml`, and `EstimateCryptoWithdrawalFeeRequest.yaml`.
How can I resolve this? If you propose a fix, please make it concise.f593795 to
26b350b
Compare

No description provided.