Skip to content

Update cryptoNetwork values#421

Open
shreyav wants to merge 1 commit intomainfrom
04-29-update_cryptonetwork_values
Open

Update cryptoNetwork values#421
shreyav wants to merge 1 commit intomainfrom
04-29-update_cryptonetwork_values

Conversation

@shreyav
Copy link
Copy Markdown
Contributor

@shreyav shreyav commented Apr 30, 2026

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Apr 30, 2026 9:15pm

Request Review

Copy link
Copy Markdown
Contributor Author

shreyav commented Apr 30, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

feat: Update cryptoNetwork values

openapi

feat: Update cryptoNetwork values

python

feat: Update cryptoNetwork values

typescript

feat: Update cryptoNetwork values

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-openapi studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️

grid-kotlin studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ✅lint ✅test ✅

grid-typescript studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ✅lint ❗test ✅

npm install https://pkg.stainless.com/s/grid-typescript/e1e87d9790c900e294c8381688c31de6e7240c22/dist.tar.gz
grid-python studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/e507504032d024a5adb81e9a2454710092e2e274/grid-0.0.1-py3-none-any.whl

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-04-30 21:20:40 UTC

@shreyav shreyav marked this pull request as ready for review April 30, 2026 04:34
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 30, 2026

Greptile Summary

This PR updates cryptoNetwork field documentation across four OpenAPI schemas, replacing verbose NETWORK_ENV values (e.g., SOLANA_MAINNET, ETHEREUM_TESTNET) with simplified network-only names (e.g., SOLANA, ETHEREUM). It also adds POLYGON and BITCOIN as newly documented networks. The source files in openapi/ were correctly edited and the generated bundles (openapi.yaml, mintlify/openapi.yaml) appear to have been properly regenerated via make build.

Confidence Score: 4/5

Safe to merge; changes are consistent documentation updates across all relevant schemas and generated bundles.

All changes are in sync across source and generated files, and no logic or code is modified. One P2 suggestion about clarifying testnet/sandbox behavior with the new simplified naming scheme.

No files require special attention; all changes are straightforward and consistent.

Important Files Changed

Filename Overview
openapi/components/schemas/crypto/EstimateCryptoWithdrawalFeeRequest.yaml Updates cryptoNetwork description and example from SOLANA_MAINNET format to simplified SOLANA format; consistent with rest of PR.
openapi/components/schemas/external_accounts/ExternalAccount.yaml Updates cryptoNetwork description and example to simplified network names; testnet variants removed without explanation of testnet behavior.
openapi/components/schemas/external_accounts/ExternalAccountCreateRequest.yaml Updates cryptoNetwork description and example from SOLANA_MAINNET to SOLANA; consistent with other schema changes.
openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml Updates cryptoNetwork description and example to simplified names; adds POLYGON and BITCOIN while removing all _MAINNET/_TESTNET variants.
openapi/paths/crypto/crypto_estimate-withdrawal-fee.yaml Updates request body example value for cryptoNetwork from SOLANA_MAINNET to SOLANA.
openapi.yaml Generated bundle (via make build) — reflects all source file changes consistently; should not be manually edited per CLAUDE.md.
mintlify/openapi.yaml Generated Mintlify bundle — reflects all source file changes consistently.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    subgraph old ["Old cryptoNetwork Values"]
        O1["SOLANA_MAINNET / SOLANA_DEVNET"]
        O2["ETHEREUM_MAINNET / ETHEREUM_TESTNET"]
        O3["BASE_MAINNET / BASE_TESTNET"]
        O4["SPARK_MAINNET / SPARK_TESTNET"]
        O5["LIGHTNING_MAINNET / LIGHTNING_REGTEST"]
    end

    subgraph new ["New cryptoNetwork Values"]
        N1["SOLANA"]
        N2["ETHEREUM"]
        N3["BASE"]
        N4["POLYGON"]
        N5["SPARK"]
        N6["LIGHTNING"]
        N7["BITCOIN"]
    end

    O1 --> N1
    O2 --> N2
    O3 --> N3
    O4 --> N5
    O5 --> N6
Loading

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
openapi/components/schemas/external_accounts/ExternalAccount.yaml:47-50
**Testnet/devnet values no longer documented**

The updated descriptions drop all environment-specific variants (`SOLANA_DEVNET`, `ETHEREUM_TESTNET`, etc.) without explaining how sandbox/testnet traffic should be handled with the new naming scheme. If the API still supports a test environment (sandbox API keys, devnet routing, etc.), developers will have no guidance on what `cryptoNetwork` value to pass in that context. Consider adding a note clarifying whether the network value is environment-agnostic (i.e., `SOLANA` is used for both mainnet and devnet, with routing determined by the API key environment) or if testnet-specific values will be introduced. The same gap applies to `ExternalAccountCreateRequest.yaml`, `RealtimeFundingQuoteSource.yaml`, and `EstimateCryptoWithdrawalFeeRequest.yaml`.

Reviews (1): Last reviewed commit: "Update cryptoNetwork values" | Re-trigger Greptile

Comment on lines 47 to 50
is a cryptocurrency wallet. Example values: SOLANA, ETHEREUM, BASE, POLYGON,
SPARK, LIGHTNING, BITCOIN.
example: SOLANA
accountInfo:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Testnet/devnet values no longer documented

The updated descriptions drop all environment-specific variants (SOLANA_DEVNET, ETHEREUM_TESTNET, etc.) without explaining how sandbox/testnet traffic should be handled with the new naming scheme. If the API still supports a test environment (sandbox API keys, devnet routing, etc.), developers will have no guidance on what cryptoNetwork value to pass in that context. Consider adding a note clarifying whether the network value is environment-agnostic (i.e., SOLANA is used for both mainnet and devnet, with routing determined by the API key environment) or if testnet-specific values will be introduced. The same gap applies to ExternalAccountCreateRequest.yaml, RealtimeFundingQuoteSource.yaml, and EstimateCryptoWithdrawalFeeRequest.yaml.

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccount.yaml
Line: 47-50

Comment:
**Testnet/devnet values no longer documented**

The updated descriptions drop all environment-specific variants (`SOLANA_DEVNET`, `ETHEREUM_TESTNET`, etc.) without explaining how sandbox/testnet traffic should be handled with the new naming scheme. If the API still supports a test environment (sandbox API keys, devnet routing, etc.), developers will have no guidance on what `cryptoNetwork` value to pass in that context. Consider adding a note clarifying whether the network value is environment-agnostic (i.e., `SOLANA` is used for both mainnet and devnet, with routing determined by the API key environment) or if testnet-specific values will be introduced. The same gap applies to `ExternalAccountCreateRequest.yaml`, `RealtimeFundingQuoteSource.yaml`, and `EstimateCryptoWithdrawalFeeRequest.yaml`.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant