fix(grid-visualizer): emit documented minimum beneficiary fields#417
Draft
fix(grid-visualizer): emit documented minimum beneficiary fields#417
Conversation
The generated curl examples included `birthDate` and `nationality` on every beneficiary (both are optional per docs) and omitted `address` even for countries where docs say it's required. Aligns the output with the minimum-required-fields table in the External Accounts docs: - All countries: emit only beneficiaryType + fullName as the universal minimum (drop birthDate / nationality — both are optional, "providing additional information... can reduce false positive compliance checks"). - US (USD), Europe (EUR), UK (GBP): include a country-appropriate beneficiary.address (line1, city, postalCode, country, optional state). - Mexico (MXN), Brazil (BRL), Philippines (PHP): explicit beneficiaryAddressRequired: false — docs call out that address is not required for these. - Other account types: left undefined so the generated payload still emits the universal minimum, since the docs only document the minimum-fields table for the six countries above. Adds BeneficiaryAddressExample type + two optional fields on AccountTypeSpec (beneficiaryAddressRequired, beneficiaryAddressExample). The code-generator's buildAccountInfoBody is updated to include the address block conditionally. Ref: https://grid.lightspark.com/payouts-and-b2b/depositing-funds/external-accounts#individual-beneficiaries Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated curl examples included
birthDateandnationalityonevery beneficiary (both are optional per docs) and omitted
addresseven for countries where docs say it's required. Aligns the output
with the minimum-required-fields table in the External Accounts docs:
minimum (drop birthDate / nationality — both are optional, "providing
additional information... can reduce false positive compliance checks").
beneficiary.address (line1, city, postalCode, country, optional state).
beneficiaryAddressRequired: false — docs call out that address is not
required for these.
emits the universal minimum, since the docs only document the
minimum-fields table for the six countries above.
Adds BeneficiaryAddressExample type + two optional fields on
AccountTypeSpec (beneficiaryAddressRequired, beneficiaryAddressExample).
The code-generator's buildAccountInfoBody is updated to include the
address block conditionally.
Ref: https://grid.lightspark.com/payouts-and-b2b/depositing-funds/external-accounts#individual-beneficiaries
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com